1195150 - Persist the tab muted state in the session store

Status: VERIFIED FIXED

(Firefox :: Session Restore, defect)

Description

[(no longer active)]

The muted state is state that belong to the whole tab, and it would be
nice if it was integrated with undo close tab and session restore.

Comment 1

[(no longer active)]

Attachment: Persist the tab muted state in the session store

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8648531 [details] [diff] [review]
Persist the tab muted state in the session store

Review of attachment 8648531 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not sure if we want to put "muted" in the attribute set here, as I would have expected to see other attribute names present if this was the desired usage here. I would redirect to Tim but he's on PTO until August 31st, but Bill has reviewed a lot of Tim's patches in this file so maybe he can give some guidance here.

Comment 3

[(no longer active)]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #2)
> I'm not sure if we want to put "muted" in the attribute set here, as I would
> have expected to see other attribute names present if this was the desired
> usage here. I would redirect to Tim but he's on PTO until August 31st, but
> Bill has reviewed a lot of Tim's patches in this file so maybe he can give
> some guidance here.

FWIW right now we use the tab attribute persistence functionality in TabAttributes.jsm only for tests, and by default we don't remember or restore any tab attributes.  Things such as the tab's pinned-ness are persisted in TabState.jsm (for example, see <http://mxr.mozilla.org/mozilla-central/source/browser/components/sessionstore/TabState.jsm#157>)

I can do something similar to that here too, but it seems easier to just piggy back on the generic attribute persistence code.

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8648531 [details] [diff] [review]
Persist the tab muted state in the session store

Review of attachment 8648531 [details] [diff] [review]:
-----------------------------------------------------------------

I think this is fine. This API is mostly designed for add-ons as far as I understand, but there's no reason we can't use it. The only danger is that some add-on is already using the name "muted". I don't see anything like that in MXR though.

Comment 5

[(no longer active)]

Comment on attachment 8648531 [details] [diff] [review]
Persist the tab muted state in the session store

Approval Request Comment
[Feature/regressing bug #]: Tab audio indicators
[User impact if declined]: See comment 0.  This is a small polish patch.
[Describe test coverage new/current, TreeHerder]: Has a test.
[Risks and why]: Extremely low risk.
[String/UUID change made/needed]: None.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7fbaf7e0566d

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/7fbaf7e0566d

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8648531 [details] [diff] [review]
Persist the tab muted state in the session store

Polish this new feature, let's take it!

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a0ff23d5fad0

Comment 10

[Camelia Badau [:cbadau], Desktop Test Engineering]

Verified fixed using latest Nightly 43.0a1 (buildID: 20150825030212) and latest Aurora 42.0a2 (buildID: 20150825004008).