Closed Bug 1211314 Opened 9 years ago Closed 9 years ago

Tab audio indicator displays incorrect tooltip after restarting the browser

Categories

(Firefox :: Tabbed Browser, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 44
Tracking Status
firefox44 --- verified

People

(Reporter: arni2033, Assigned: ehsan.akhgari)

References

Details

Attachments

(2 files)

STR:   (Win7_64, Nightly 44, 32bit, ID 20151004030211, new profile, safe mode)
1. Open new tab (https://www.mozilla.org/en-US/about)
2. Play video in the page
3. Mute the tab
4. Switch to another page
5. Make sure you have option "don't load tab until selected" enabled. Restart the browser
6. Move mouse over the sound indicator on tab in Step 1

Result:       Tooltip is wrong (and button is functioning wrong)
Expectations: Tooltip should be correct; pressing sound indicator
              should unmute the pending tab from Step 1
It seems like the solution to bug 1195150 is incomplete.  What happens here is that we end up calling setAttribute("muted", "true") on the tab but we never call mute() on it, so its audioMuted property remains false.  We later on correct this in onStateChange but this is visible before that stage as comment 0 suggests.

I think we need to start using toggleMuteAudio() in sessionstore, similar to what we do with pinTab and unpinTab.
Assignee: nobody → ehsan
Blocks: 1195150
No longer blocks: 486262
Attachment #8673793 - Flags: review?(jaws) → review+
https://hg.mozilla.org/mozilla-central/rev/66960bd73049
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Flags: qe-verify+
Verified fixed on Firefox 44 Beta 2 (buildID: 20151221151411).
Status: RESOLVED → VERIFIED
Has STR: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: