1195211 - Geolocation API doesnt work on the Stingray TV

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Paul Theriault [:pauljt] (no longer reading bugmail)]

Geolocation doesnt seem to work on the TV. THere is no prompt shown and access to the API fails.

STR: navigate to http://html5demos.com/geo

Expected: geolocation prompt then access to the API

Actual: No access to the API. In the browser app, an error message is shown. In other apps no error is shown.

Comment 1

[Aaron Train [:aaronmt]]

What are you referring to when you mention 'tv'? Apple AirPlay Mirroring? What is your setup and configuration?

Comment 2

[Paul Theriault [:pauljt] (no longer reading bugmail)]

Sorry I messed up filing here, wrong product and I didnt bloc the bug i meant to block. Sorry for distraction.

Comment 3

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

I don't think Stingray TV has geolocation sensor, but maybe it can leverage the same geolocation technology we have on Firefox Desktop.

Comment 4

[Ben Tian (inactive)]

Alphan, can you check this bug on TV with SC?

Comment 5

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Discussed with kanru on IRC, we have a fallback network location service in gecko already. However, for b2g we didn't turn on the fallback service by default. The first thing we need to fix is setting pref |geo.provider.use_mls| to true for Stingray TV [1] since it doesn't have geolocation sensor on platform.

[1] https://dxr.mozilla.org/mozilla-central/source/b2g/app/b2g.js#202

Comment 6

[Alphan Chen [:alchen]]

Clear ni first since there are some findings in comment 5.

Comment 7

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Hi Kusaba-san, could you follow comment #5 to enable network location service on stingray TV?

Comment 8

[Daisuke]

Attachment: geolocation is available by adding geo permission to web browser

(In reply to Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz) from comment #7)
> Hi Kusaba-san, could you follow comment #5 to enable network location
> service on stingray TV?

This report said that geolocation access is not available on WebPage on WebBrowser of TV(stingray).
Just WebBrowser of TV(stingray) lacks "geolocation" permission in its manifest and after add it, geolocation is available as attached.

So will correct stingray browser app's manifest.

Comment 9

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Great! I double checked the source code and confirmed the logic of using NetworkGeolocationProvider as a fallback. Good to know there is an easy fix for this issue. Feel free to provide the scheduled OTA date and close this bug.

Comment 10

[Josh Cheng [:josh]]

Bug 1220066 opened for disabling this. We currently do not have Settings on TV.
Evelyn, any alternative before we have Settings on TV ready?

Comment 11

[Josh Cheng [:josh]]

One more question would be 
"How do we use cursor on TV for permission confirmation?"

Comment 12

[Evelyn Hung]

(In reply to Josh Cheng [:josh] from comment #11)
> One more question would be 
> "How do we use cursor on TV for permission confirmation?"

Permission prompt UI has been TV optimized in bug 1217765. 

Let's add permission to browser app and let QA verify it on TV. For settings problem, we have no alternative solution and System will remember the first answer from the user. It's a bug but I feel it shouldn't be a blocker to prevent us supporting this API.

Assign to yifan to add geolocation permission for browser app.

Comment 13

[GitHub Autolander Bot]

Attachment: [gaia] begeeben:1195211_geolocation_api > mozilla-b2g:master

Comment 14

[Evelyn Hung]

[Blocking Requested - why for this release]:

Comment 15

[yifan [:yifan][:yliao]]

Comment on attachment 8705047 [details] [review]
[gaia] begeeben:1195211_geolocation_api > mozilla-b2g:master

Thanks!

Comment 16

[Evelyn Hung]

Comment on attachment 8705047 [details] [review]
[gaia] begeeben:1195211_geolocation_api > mozilla-b2g:master

Thanks!!!

Comment 17

[Evelyn Hung]

merged into master:
https://github.com/mozilla-b2g/gaia/commit/2fd4e124028226668fe50228801df424632a29ce

Please request a? for uplift. Thanks.

Comment 18

[yifan [:yifan][:yliao]]

Comment on attachment 8705047 [details] [review]
[gaia] begeeben:1195211_geolocation_api > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Geolocation API will fail to provide the position to requests on the TV broser
[Testing completed]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=75b757ed4341bee0e2f905c50c5a4f8a965f1502
[Risk to taking this patch] (and alternatives if risky): none
[String changes made]: none

Comment 19

[Josh Cheng [:josh]]

Comment on attachment 8705047 [details] [review]
[gaia] begeeben:1195211_geolocation_api > mozilla-b2g:master

Approve for 2.5

Comment 20

[Carsten Book [:Tomcat]]

for 2.5 https://github.com/mozilla-b2g/gaia/commit/e2384c15e8932df6dca879d1227467706e67b080