1195216 - Last tab is cut off in tab tray in portrait

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Teodora Vermesan (:TeoVermesan)]

Attachment: Screenshot_2015-08-17-12-06-49.png

Tested with:
Device: Nexus 4 (Android 5.0.1), Alcatel One Touch (Android 4.1.2)
Build: Firefox for Android 43.0a1 (2015-08-17)

Steps to reproduce:
1. Open 5 tabs in portrait
2. Open tab tray

Expected results:
- Tabs are displayed correctly in tab tray.

Actual results:
- The last tab is cut off.

Comment 1

[Martyn Haigh (:mhaigh)]

Attachment: MozReview Request: Bug 1195216 - Last tab is cut off in tab tray in portrait; r?mcomella

Bug 1195216 - Last tab is cut off in tab tray in portrait; r?mcomella

In this patch we remove the custom height measurement belonging to the TabsLayoutContainer, which was making the TabsList bigger than it needed to be.  As a result of this change, we can then remove the TabsLayoutContainer altogether. This resulted in a small change needed to ensure that the empty view in the private tabs tray was correctly centred.

Comment 2

[Martyn Haigh (:mhaigh)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=195e773b4b06

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8648736 [details]
MozReview Request: Bug 1195216 - Last tab is cut off in tab tray in portrait; r?mcomella

https://reviewboard.mozilla.org/r/16273/#review14607

Ship It!

Comment 4

[Martyn Haigh (:mhaigh)]

url:        https://hg.mozilla.org/integration/fx-team/rev/746ac829b15af5cd065d6866de6a7e074ad34a47
changeset:  746ac829b15af5cd065d6866de6a7e074ad34a47
user:       Martyn Haigh <[e-mail]>
date:       Mon Aug 17 15:16:42 2015 +0100
description:
Bug 1195216 - Last tab is cut off in tab tray in portrait; r=mcomella

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/746ac829b15a