Closed Bug 1195216 Opened 4 years ago Closed 4 years ago

Last tab is cut off in tab tray in portrait

Categories

(Firefox for Android :: General, defect)

43 Branch
ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 43
Tracking Status
firefox43 --- fixed

People

(Reporter: TeoVermesan, Assigned: mhaigh)

References

Details

Attachments

(2 files)

Tested with:
Device: Nexus 4 (Android 5.0.1), Alcatel One Touch (Android 4.1.2)
Build: Firefox for Android 43.0a1 (2015-08-17)

Steps to reproduce:
1. Open 5 tabs in portrait
2. Open tab tray

Expected results:
- Tabs are displayed correctly in tab tray.

Actual results:
- The last tab is cut off.
Assignee: nobody → mhaigh
Status: NEW → ASSIGNED
Bug 1195216 - Last tab is cut off in tab tray in portrait; r?mcomella

In this patch we remove the custom height measurement belonging to the TabsLayoutContainer, which was making the TabsList bigger than it needed to be.  As a result of this change, we can then remove the TabsLayoutContainer altogether. This resulted in a small change needed to ensure that the empty view in the private tabs tray was correctly centred.
Attachment #8648736 - Flags: review?(michael.l.comella)
Comment on attachment 8648736 [details]
MozReview Request: Bug 1195216 - Last tab is cut off in tab tray in portrait; r?mcomella

https://reviewboard.mozilla.org/r/16273/#review14607

Ship It!
Attachment #8648736 - Flags: review?(michael.l.comella) → review+
url:        https://hg.mozilla.org/integration/fx-team/rev/746ac829b15af5cd065d6866de6a7e074ad34a47
changeset:  746ac829b15af5cd065d6866de6a7e074ad34a47
user:       Martyn Haigh <mhaigh@mozilla.org>
date:       Mon Aug 17 15:16:42 2015 +0100
description:
Bug 1195216 - Last tab is cut off in tab tray in portrait; r=mcomella
https://hg.mozilla.org/mozilla-central/rev/746ac829b15a
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
You need to log in before you can comment on or make changes to this bug.