Last tab is cut off in tab tray in portrait

RESOLVED FIXED in Firefox 43

Status

()

Firefox for Android
General
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: TeoVermesan, Assigned: mhaigh)

Tracking

43 Branch
Firefox 43
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox43 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
Created attachment 8648631 [details]
Screenshot_2015-08-17-12-06-49.png

Tested with:
Device: Nexus 4 (Android 5.0.1), Alcatel One Touch (Android 4.1.2)
Build: Firefox for Android 43.0a1 (2015-08-17)

Steps to reproduce:
1. Open 5 tabs in portrait
2. Open tab tray

Expected results:
- Tabs are displayed correctly in tab tray.

Actual results:
- The last tab is cut off.
(Assignee)

Updated

3 years ago
Assignee: nobody → mhaigh
Status: NEW → ASSIGNED
(Assignee)

Comment 1

3 years ago
Created attachment 8648736 [details]
MozReview Request: Bug 1195216 - Last tab is cut off in tab tray in portrait; r?mcomella

Bug 1195216 - Last tab is cut off in tab tray in portrait; r?mcomella

In this patch we remove the custom height measurement belonging to the TabsLayoutContainer, which was making the TabsList bigger than it needed to be.  As a result of this change, we can then remove the TabsLayoutContainer altogether. This resulted in a small change needed to ensure that the empty view in the private tabs tray was correctly centred.
Attachment #8648736 - Flags: review?(michael.l.comella)
Comment on attachment 8648736 [details]
MozReview Request: Bug 1195216 - Last tab is cut off in tab tray in portrait; r?mcomella

https://reviewboard.mozilla.org/r/16273/#review14607

Ship It!
Attachment #8648736 - Flags: review?(michael.l.comella) → review+
(Assignee)

Comment 4

3 years ago
url:        https://hg.mozilla.org/integration/fx-team/rev/746ac829b15af5cd065d6866de6a7e074ad34a47
changeset:  746ac829b15af5cd065d6866de6a7e074ad34a47
user:       Martyn Haigh <mhaigh@mozilla.org>
date:       Mon Aug 17 15:16:42 2015 +0100
description:
Bug 1195216 - Last tab is cut off in tab tray in portrait; r=mcomella
https://hg.mozilla.org/mozilla-central/rev/746ac829b15a
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox43: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
See Also: → bug 1217109
You need to log in before you can comment on or make changes to this bug.