1217109 - bottom tab in tabs tray cut off

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: 2015-10-21 17.56.58.png

The orange highlight is certainly cut off, its not clear to me if any of the thumbnail is cut off or not

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f423f07d444c

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1217109 - Remove OuterLayout and drag handling. r?margaret

Bug 1217109 - Remove OuterLayout and drag handling. r?margaret

After switching to a full screen tabs tray there's no chrome to drag anymore.

Comment 3

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1217109 - Replace TabsLayoutContainer with RelativeLayout. r?margaret

Bug 1217109 - Replace TabsLayoutContainer with RelativeLayout. r?margaret

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1217109 - TabsPanel: Remove unused methods. r?margaret

Bug 1217109 - TabsPanel: Remove unused methods. r?margaret

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

The patches might look a bit scary. :) The issue was caused by code fiddling with the measurements in order to support dragging the browser chrome in the tabs tray. This is not possible anymore since we switched to a full screen tabs tray. So I ripped it all out.

Try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f423f07d444c

Comment 6

[:Margaret Leibovic]

Comment on attachment 8678092 [details]
MozReview Request: Bug 1217109 - Remove OuterLayout and drag handling. r?margaret

https://reviewboard.mozilla.org/r/23099/#review20575

I think it makes sense to remove this drag behavior, now that the UX paradigm is different with the full screen tabs tray. However, we should double check with antlam to make sure this change is intentional.

Also, I'll leave you the pleasure of going through bug 909434 to resolve WONTFIX or INVALID all the outstanding dependencies.

Looking at the changeset for the initial change that landed to implement this, there may also now be unused things in BrowserToolbar that we could get rid of:
http://hg.mozilla.org/mozilla-central/rev/93840f9b5af8

Comment 7

[:Margaret Leibovic]

Comment on attachment 8678093 [details]
MozReview Request: Bug 1217109 - Replace TabsLayoutContainer with RelativeLayout. r?margaret

https://reviewboard.mozilla.org/r/23101/#review20577

Comment 8

[:Margaret Leibovic]

Comment on attachment 8678094 [details]
MozReview Request: Bug 1217109 - TabsPanel: Remove unused methods. r?margaret

https://reviewboard.mozilla.org/r/23103/#review20579

Comment 9

[Sebastian Kaspari (:sebastian; :pocmo)]

I talked to antlam and he gave green light. I'm going to land these changes now.

Comment 10

[Sebastian Kaspari (:sebastian; :pocmo)]

https://hg.mozilla.org/integration/fx-team/rev/a41e03e7fdbf8db414838b2d13678b69ce0a7f7e
Bug 1217109 - Remove OuterLayout and drag handling. r=margaret

https://hg.mozilla.org/integration/fx-team/rev/b2a024a24fcf5b5c5d4e86984fcf1a3faa36c25a
Bug 1217109 - Replace TabsLayoutContainer with FrameLayout. r=margaret

https://hg.mozilla.org/integration/fx-team/rev/ed95da49fb0094d954646bca24f912b28985262b
Bug 1217109 - TabsPanel: Remove unused methods. r=margaret

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a41e03e7fdbf
https://hg.mozilla.org/mozilla-central/rev/b2a024a24fcf
https://hg.mozilla.org/mozilla-central/rev/ed95da49fb00

Comment 12

[Teodora Vermesan (:TeoVermesan)]

Attachment: Screenshot_2015-10-28-12-18-56.png

Verified as fixed using:
Build: Firefox 44.0a1 (2015-10-27)
Device: Samsung S5 (Android 4.4.2)