Closed Bug 1217109 Opened 4 years ago Closed 4 years ago

bottom tab in tabs tray cut off

Categories

(Firefox for Android :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 44
Tracking Status
firefox44 --- verified
fennec 44+ ---

People

(Reporter: blassey, Assigned: sebastian)

References

(Blocks 1 open bug)

Details

Attachments

(5 files)

Attached image 2015-10-21 17.56.58.png
The orange highlight is certainly cut off, its not clear to me if any of the thumbnail is cut off or not
Assignee: nobody → s.kaspari
Blocks: tabs-tray
tracking-fennec: ? → 44+
See Also: → 1195216, 1132508
Bug 1217109 - Remove OuterLayout and drag handling. r?margaret

After switching to a full screen tabs tray there's no chrome to drag anymore.
Attachment #8678092 - Flags: review?(margaret.leibovic)
Bug 1217109 - Replace TabsLayoutContainer with RelativeLayout. r?margaret
Attachment #8678093 - Flags: review?(margaret.leibovic)
Bug 1217109 - TabsPanel: Remove unused methods. r?margaret
Attachment #8678094 - Flags: review?(margaret.leibovic)
The patches might look a bit scary. :) The issue was caused by code fiddling with the measurements in order to support dragging the browser chrome in the tabs tray. This is not possible anymore since we switched to a full screen tabs tray. So I ripped it all out.

Try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f423f07d444c
Comment on attachment 8678092 [details]
MozReview Request: Bug 1217109 - Remove OuterLayout and drag handling. r?margaret

https://reviewboard.mozilla.org/r/23099/#review20575

I think it makes sense to remove this drag behavior, now that the UX paradigm is different with the full screen tabs tray. However, we should double check with antlam to make sure this change is intentional.

Also, I'll leave you the pleasure of going through bug 909434 to resolve WONTFIX or INVALID all the outstanding dependencies.

Looking at the changeset for the initial change that landed to implement this, there may also now be unused things in BrowserToolbar that we could get rid of:
http://hg.mozilla.org/mozilla-central/rev/93840f9b5af8
Attachment #8678092 - Flags: review?(margaret.leibovic) → review+
Comment on attachment 8678093 [details]
MozReview Request: Bug 1217109 - Replace TabsLayoutContainer with RelativeLayout. r?margaret

https://reviewboard.mozilla.org/r/23101/#review20577
Attachment #8678093 - Flags: review?(margaret.leibovic) → review+
Comment on attachment 8678094 [details]
MozReview Request: Bug 1217109 - TabsPanel: Remove unused methods. r?margaret

https://reviewboard.mozilla.org/r/23103/#review20579
Attachment #8678094 - Flags: review?(margaret.leibovic) → review+
I talked to antlam and he gave green light. I'm going to land these changes now.
Verified as fixed using:
Build: Firefox 44.0a1 (2015-10-27)
Device: Samsung S5 (Android 4.4.2)
You need to log in before you can comment on or make changes to this bug.