We are intentionally letting the installer run with the browser open until the last minute in the installation. That being the case, the message that the user gets when it is time to shut the browser down and finish the installation should not be presented as an error message. Further, it needs to be pretty informative so the user knows exactly what is going on. Gregg, I could use help with the verbage.
Created attachment 65185 [details] The attachment is a screen shot of the existing dialogue box Yes, the language definitely needs to be reworded. I will take a first pass at it and then send over to Steve Rudman for polish. Currently it says: Window Title - "Error" "Setup has detected that an instance of Netscape 6 is currently running. Please quit Netscape 6 before continuing Setup. Click retry to perform the check again, or Cancel to exit Setup." Buttons: "Retry" and "Cancel" For the new dialogue box, as Grace said, we are intentionally keeping the browser window open because we will be serving the setup file as an xpi and "auto-running" the installer. We need a smooth way of shutting down the apps after download and before install. Ideally, the dialogue box that comes up after successful download would have an "OK" button ONLY that automatically shuts down all 6.x apps and proceeds to the install. If we can get to this point, the dialogue box should say something like: Window Title - "Attention" "Download of Netscape 6 is successful. All instances of Netscape 6 must now be closed to proceed to installation. Click OK to install." Button - "Ok" *OR* Window Title - "Attention" "Setup will now close down all instances of Netscape 6 (or "all Windows programs", depending on what is do-able and/or best). Click Ok to proceed to installation." Button - "Ok"
For the first round I think we'd better assume that the user is going to have to shut down the browser. In that event, I don't believe it is good enough to say "All instances of Netscape 6 must now be closed" because just closing the browser windows doesn't always close all the ns processes and then the user is going to be bemused. We'll need to say something more like "Please select File|Exit from the browser window to close all instances of Netscape 6". Also, do we want to proved a Cancel button as well as the Ok button? I can't think of a reason that a user would want to cancel at this point but I know that, if for some reason he cannot proceed, it is sure aggravating not be able to get out of a program.
Need to handle the process used by QuickLaunch also- I know Installer and Uninstaller close that without notifying user now
Created attachment 66229 [details] [diff] [review] 0.1 patch There is at least one problem with this patch for sure. Clicking the x in the top right corner does not get the user out of this dialog. Since the only button offered is an OK button the only way to get out CTRL-ALT-DEL. Gregg I think we are going to have to include a cancel button on here.
I put a bmp of a screenshot of the MessageBox at http://blues.netscape.com/users/curt/publish/xpinstall/attention.bmp.
I am ok with having an extra button, but I would prefer it said 'Quit' instead of 'Cancel'
Adding Jatin for verbiage help.
Assuming that Quick Launch will be automatically disabled by the installation, this is my suggested wording: "Download of $ProductName$ is successful. Close any $ProductName$ windows to proceed with installation. To do this, open the File menu in $ProductName$ and choose Exit. Then click OK in this dialog box to continue installation." Quit is preferable to Cancel, since "Cancel" infers that the user state is reverted, when in actuality installation files have placed on the user's hard drive.
Without creating a new dialog box, Ok/Quit is not an option. This is using a simple MessageBox and the only applicable options seem to be Ok/Cancel or Retry/Cancel. For the record, I believe that currently we do return the user's machine to the original state, although I think we would like to change that. Unless I'm mistaken, we clean up the downloaded files if we cancel at this point. At the very least we don't use them the next time the user tries to install. I think we should so, if I "correct" that behavior in the near future your assumption will be true but, technically, I don't believe it is true now. Back to the subject at hand, though: I recommend we go with the Retry/Cancel option. Further (although I'm volunteering myself for some more work) I think we should probably link a "Are you sure you want to Cancel" MessageBox to the Cancel button. Besides helping the user avoid accidentally aborting, we could give a little information about the consequences of cancelling if we do, in fact, decide not to clean up downloaded files behind ourselves.
Using 'Cancel' is fine with me provided that an extra dialogue comes up like you said instructing the user how to install later if they in fact select cancel. We will again need language on what exactly to say. I don't want to use 'Retry' as the proceed button, because it doesn't make sense in this context. It should be click 'OK' to proceed with installation. Please keep in mind, that this dialogue should only be shown if the user has a 6.x app open, not IE or 4.x.
Summary: Change error message to warning message when browser needs shut down → [rfe]Change error message to warning message when browser needs shut down
Whiteboard: mcp-working → [mcp-working]
Changing the summary to be more generic since what we do for this bug depends upon whether we can successfully implement bug 110822. If we can shut down the browser for the user we wont need to address bug 122692, either.
Summary: [rfe]Change error message to warning message when browser needs shut down → [rfe]Change error message about need to shut down browser after download
Since we would really like for the installer to close the browser, and since this depends upon bug 99940, and since Bill Law says this will be fixed in time for Mozilla 1.0... I'm going to work off the assumption--as long as possible--that we are going to be able to shut down the browser for user and so will need only a single Okay button on this dialog. I'll implement it that way for now and when Bill gets the dependency bug fixed we'll just change the verbiage in this message box and have it call his command-line option. In the meantime we'll get a chance to see if user really have a seriously tough time closing the browsers themselves, and whether the Cancel button is a requirement if we don't get what is needed to close the browser for them. I'm also closing 122692 as invalid since we won't need it under this scenerio. We can reopen it if have to change routes later.
only nsbeta1+ bugs can have milestones, resetting to ---
Target Milestone: mozilla0.9.9 → ---
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.9
Attachment #66229 - Attachment is obsolete: true
Created attachment 68278 [details] [diff] [review] 0.2 patch to create the MessageBox with only an Okay button
adding the requisite plus, only nsbeta1+ bugs can have a milestone
Keywords: nsbeta1 → nsbeta1+
How about "was successful", not "is successful" ? Other than that, looks ok to me.
How about "was successful", not "is successful" ? The "Attention" text in the 0.2 patch, that needs to be localizable i would guess. Is there something wrong with just using the NULL instead?
Comment on attachment 68278 [details] [diff] [review] 0.2 patch to create the MessageBox with only an Okay button you shouldn't hard code "Attention". You can put it in install.it and read it from there. szFileIniInstall will contain the full path to install.ini. you can use that in a GetPrivateProfileString() call. You can search for szFileIniInstall in the setup code for examples.
Attachment #68278 - Flags: needs-work+
Created attachment 68510 [details] [diff] [review] Updates for mozilla This adds the "Attention" string to install.it and makes the cosmetic change Syd requested.
Comment on attachment 68510 [details] [diff] [review] Updates for mozilla r=ssu
Attachment #68510 - Flags: review+
Comment on attachment 68511 [details] [diff] [review] ns gets an update, too. r=ssu
Attachment #68511 - Flags: review+
Comment on attachment 68511 [details] [diff] [review] ns gets an update, too. >-Message=Setup has detected that an instance of $ProductName$ is currently running. Please quit $ProductName$ before continuing Setup. Click Retry to perform the check again, or Cancel to exit Setup. >+Message=Download of $ProductName$ was successful. All instances of $ProductName$ must now be closed to proceed to installation. Select File|Exit from the browser window. Then click Ok to Install. This isn't quite the text Gregg or Jatin suggested, and it's a little clunky. Ditto the other patch.
Comment on attachment 68510 [details] [diff] [review] Updates for mozilla sr=dveditz but I'd prefer you change the message text
Attachment #68510 - Flags: superreview+
Created attachment 69446 [details] [diff] [review] Corrected text only. I obviously lifted the text being wrong. The only difference in this text and that above should be the change of "is" to "was" that Syd suggested.
Created attachment 69447 [details] [diff] [review] Corrected text only. I obviously lifted the text being wrong. The only difference in this text and that above should be the change of "is" to "was" that Syd suggested.
Attachment #68510 - Attachment is obsolete: true
Attachment #69446 - Attachment is obsolete: true
Checked in both mozilla and ns with the corrected text.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
Looks good on both NS and Mozilla build 2002021503
Status: RESOLVED → VERIFIED
[RFE] is deprecated in favor of severity: enhancement. They have the same meaning.
Severity: normal → enhancement
You need to log in before you can comment on or make changes to this bug.