Closed Bug 1195364 Opened 4 years ago Closed 4 years ago

Create an acceptance test which checks that "Pressing home button does nothing on the lockscreen"

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: jlorenzo, Assigned: jlorenzo)

References

Details

Attachments

(1 file)

Assignee: nobody → jlorenzo
No flakiness to report but I did break some tests. I'll investigate them.
The brokenness job in comment 4 lost the connection to b2g. Same thing for the following job: http://jenkins1.qa.scl3.mozilla.com/job/flame-kk.ui.adhoc/872/console

I'll try to split the job into 2 to see if we can get more reliable results.
The connection lost from b2g was due to a gecko bug. Retrying http://jenkins1.qa.scl3.mozilla.com/job/flame-kk.ui.adhoc/881/
Comment on attachment 8649891 [details] [review]
[gaia] JohanLorenzo:bug-1195364 > mozilla-b2g:master

I got a build that shows that no regression happened in the test suite: http://jenkins1.qa.scl3.mozilla.com/job/flame-kk.ui.adhoc/882/consoleFull

The test is not flaky: http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/871/console

What do you guys think?
Attachment #8649891 - Flags: review?(martijn.martijn)
Attachment #8649891 - Flags: review?(jdorlus)
Comment on attachment 8649891 [details] [review]
[gaia] JohanLorenzo:bug-1195364 > mozilla-b2g:master

I added some comments/questions/suggestions in the pull request.
I'm more wondering about these ._handle_home_button_event_in_homescreen/_handle_home_button_event_in_lockscreen methods.
It seems to me like it would be better if you wrote separate tests for these, instead of adding this as part of touch_home_button().
Something like test_homescreen_home_button_edit_mode.py for example, or something like that.
What do you think?
Attachment #8649891 - Flags: review?(martijn.martijn)
Comment on attachment 8649891 [details] [review]
[gaia] JohanLorenzo:bug-1195364 > mozilla-b2g:master

Thanks for the review! The point you raised caught a false positive. I updated the test.

Concerning _handle_home_button_event_in_homescreen() and _handle_home_button_event_in_lockscreen(), I created 2 other tests in the PR, in order to check that these paths are covered.

I'm not sure what you mean by not putting this calls in touch_home_button(). The home button doesn't have the same behavior depending on where you press on it. Hence, having the behavior centralized there sounds closer to what the button should do. What do you think?
Attachment #8649891 - Flags: review?(martijn.martijn)
Comment on attachment 8649891 [details] [review]
[gaia] JohanLorenzo:bug-1195364 > mozilla-b2g:master

(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #10)
> I'm not sure what you mean by not putting this calls in touch_home_button().
> The home button doesn't have the same behavior depending on where you press
> on it. Hence, having the behavior centralized there sounds closer to what
> the button should do. What do you think?

Sorry, you're right. This is already done here and it's the most logical thing to do.
I did some testing and everything passed.
Attachment #8649891 - Flags: review?(martijn.martijn) → review+
Comment on attachment 8649891 [details] [review]
[gaia] JohanLorenzo:bug-1195364 > mozilla-b2g:master

Sorry this took so long.
Attachment #8649891 - Flags: review?(jdorlus) → review+
FYI: Still waiting on bug 1188926 to land this patch.
Johan, bug 1188926 is fixed now, so I guess this pull request can be merged now or is this not useful anymore?
Flags: needinfo?(jlorenzo)
Like discussed back in the work week, these tests would have more value as a Gij one. They only verify the integration between gecko and gaia (we emulate the home button being pressed thanks to some Gaia code). 

I couldn't find any equivalent in the Gij suite. I filed bug 1232280 and bug 1232281 to implement them.
Status: NEW → RESOLVED
Closed: 4 years ago
Flags: needinfo?(jlorenzo)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.