1195364 - Create an acceptance test which checks that "Pressing home button does nothing on the lockscreen"

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Johan Lorenzo [:jlorenzo]]

https://moztrap.mozilla.org/manage/case/15904/

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] JohanLorenzo:bug-1195364 > mozilla-b2g:master

Comment 2

[Johan Lorenzo [:jlorenzo]]

The PR is ready.

Job to check the flakiness of the new test: http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/867/console
Job that checks that no b2g test is broken: http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/868/console

Comment 3

[Johan Lorenzo [:jlorenzo]]

No flakiness to report but I did break some tests. I'll investigate them.

Comment 4

[Johan Lorenzo [:jlorenzo]]

Updated PR, let's create new jobs.

Flakiness: http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/871/console
Brokenness: http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/870/console

Comment 5

[Johan Lorenzo [:jlorenzo]]

The brokenness job in comment 4 lost the connection to b2g. Same thing for the following job: http://jenkins1.qa.scl3.mozilla.com/job/flame-kk.ui.adhoc/872/console

I'll try to split the job into 2 to see if we can get more reliable results.

Comment 6

[Johan Lorenzo [:jlorenzo]]

The connection lost from b2g was due to a gecko bug. Retrying http://jenkins1.qa.scl3.mozilla.com/job/flame-kk.ui.adhoc/881/

Comment 7

[Johan Lorenzo [:jlorenzo]]

New try: http://jenkins1.qa.scl3.mozilla.com/job/flame-kk.ui.adhoc/882/console

Comment 8

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8649891 [details] [review]
[gaia] JohanLorenzo:bug-1195364 > mozilla-b2g:master

I got a build that shows that no regression happened in the test suite: http://jenkins1.qa.scl3.mozilla.com/job/flame-kk.ui.adhoc/882/consoleFull

The test is not flaky: http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/871/console

What do you guys think?

Comment 9

[Martijn Wargers (dead)]

Comment on attachment 8649891 [details] [review]
[gaia] JohanLorenzo:bug-1195364 > mozilla-b2g:master

I added some comments/questions/suggestions in the pull request.
I'm more wondering about these ._handle_home_button_event_in_homescreen/_handle_home_button_event_in_lockscreen methods.
It seems to me like it would be better if you wrote separate tests for these, instead of adding this as part of touch_home_button().
Something like test_homescreen_home_button_edit_mode.py for example, or something like that.
What do you think?

Comment 10

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8649891 [details] [review]
[gaia] JohanLorenzo:bug-1195364 > mozilla-b2g:master

Thanks for the review! The point you raised caught a false positive. I updated the test.

Concerning _handle_home_button_event_in_homescreen() and _handle_home_button_event_in_lockscreen(), I created 2 other tests in the PR, in order to check that these paths are covered.

I'm not sure what you mean by not putting this calls in touch_home_button(). The home button doesn't have the same behavior depending on where you press on it. Hence, having the behavior centralized there sounds closer to what the button should do. What do you think?

Comment 11

[Martijn Wargers (dead)]

Comment on attachment 8649891 [details] [review]
[gaia] JohanLorenzo:bug-1195364 > mozilla-b2g:master

(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #10)
> I'm not sure what you mean by not putting this calls in touch_home_button().
> The home button doesn't have the same behavior depending on where you press
> on it. Hence, having the behavior centralized there sounds closer to what
> the button should do. What do you think?

Sorry, you're right. This is already done here and it's the most logical thing to do.
I did some testing and everything passed.

Comment 12

[John Dorlus [:Silne30]]

Comment on attachment 8649891 [details] [review]
[gaia] JohanLorenzo:bug-1195364 > mozilla-b2g:master

Sorry this took so long.

Comment 13

[Johan Lorenzo [:jlorenzo]]

FYI: Still waiting on bug 1188926 to land this patch.

Comment 14

[Martijn Wargers (dead)]

Johan, bug 1188926 is fixed now, so I guess this pull request can be merged now or is this not useful anymore?

Comment 15

[Johan Lorenzo [:jlorenzo]]

Like discussed back in the work week, these tests would have more value as a Gij one. They only verify the integration between gecko and gaia (we emulate the home button being pressed thanks to some Gaia code). 

I couldn't find any equivalent in the Gij suite. I filed bug 1232280 and bug 1232281 to implement them.