1195394 - add an option to limit the persist folder size

Status: RESOLVED FIXED

(Testing :: mozregression, defect)

Description

[Julien Pagès (:parkouss)]

We should add an option to limit the persist folder size.

A good default would be 1G I guess, like we currently use for http-cache-request (soon to be removed).

We should remove older builds when we reach the limit.

Comment 1

[Elbart]

1GiB is about 10 OSX-Nightlies or 20 Win/Linux-Nightlies. That's not a lot.

When doing an inbound-bisection, you'd eventually end up deleting Nightlies you bisected in the same session earlier.

Comment 2

[Julien Pagès (:parkouss)]

hm right. We probably should make the default higher.

What do you think would make a good default ?

Comment 3

[MikeLing]

Maybe we could let user defined the folder size by themselves, and it's open to resize by user if they think it's not enough in their further work.

Comment 4

[Julien Pagès (:parkouss)]

(In reply to MikeLing from comment #3)
> Maybe we could let user defined the folder size by themselves, and it's open
> to resize by user if they think it's not enough in their further work.

Sure, the user will be able to change the default - but we should provide a good default, good for most people that use mozregression.

With comment 1, I now think 1GiB is really not enough. Maybe 20 ?

Comment 5

[jonathan.pigree]

20 GiB seems pretty much for me. I don't know if mozregression users have pretty big hard drives, but if it is a default option, it should'not be too much. The user might not suspect that mozregression actually keeps on piling up archives in some directory.

At least, print a BIG warning first, or even, on the first time use, mozregression directly ask the user the size he wants (with 20GiB advised perhaps?) and stores it in a configuration file. It is the most explicit way.

The only other way I can think of is when the limit is reached, to ask the user if wants to increase the limit or erase some archives.

Comment 6

[Julien Pagès (:parkouss)]

I like the idea of asking the user the first time!

Well asking a question when the limit is reached may be an issue for some use cases. We have the --command that allows to execute a command to evaluate a build (instead of manual testing). I would prefer this to not be possibly blocked by a question like this.

Comment 7

[jonathan.pigree]

You are right. Actually, I prefer the first idea like you. It is simple, explicit and only an one time prompt.

Comment 8

[Julien Pagès (:parkouss)]

Attachment: limit persist folder size

So this does not change the default, we will see that in another bug.

This only add a --persist-size-limit that takes a value in GiB to limit the size of the persist dir. Note that there is a hardcoded limit of 5 builds minimum, regardless of the value of the limit.

Comment 9

[William Lachance (:wlach)]

Comment on attachment 8652267 [details] [review]
limit persist folder size

This looks good! Thanks.

Comment 10

[Julien Pagès (:parkouss)]

Thanks! Fixed the nits and landed in https://github.com/mozilla/mozregression/commit/7da07b7230e67dd6ec034c500d3157ab8c896c7d