1195395 - mozregression should use a persist folder by default

Status: RESOLVED WORKSFORME

(Testing :: mozregression, defect)

Description

[Julien Pagès (:parkouss)]

mozregression should use a persist folder by default. This would be good for new users, as future bisections may reuse already downloaded builds without any special user interaction.

Comment 1

[Elbart]

Will the location be user-definable?

Comment 2

[Julien Pagès (:parkouss)]

Sure. :) If you already use a config file and defined a destination in there, it will also be used (hm, maybe we will move the location of that file in the same time, this needs discussion).

This is just that the default will no more be "no persist", but a folder in the user directory configuration. But if specified, (command line or config) the user choice will be respected.

Comment 3

[jonathan.pigree]

Seems pretty awesome to me. Indeed, new users should have this option enabled without interaction. This is, I think, how most people would want the tool to behave.

Why do you want to move the config file? In my opinion, it is fine to have it into user directory.

Comment 4

[Julien Pagès (:parkouss)]

(In reply to jonathan.pigree from comment #3)
> Seems pretty awesome to me. Indeed, new users should have this option
> enabled without interaction. This is, I think, how most people would want
> the tool to behave.
> 
> Why do you want to move the config file? In my opinion, it is fine to have
> it into user directory.

Well, it will stay in user directory. This is just that for now, the config is in:

~/.mozregression.cfg

I would prefer to have everything in one folder, so maybe something like:

~/.mozilla/mozregression/mozregression.cfg
~/.mozilla/mozregression/persist

Comment 5

[jonathan.pigree]

Okay. I searched for a standard logic on where to put the config file in my tools (maven, gradle, git, npm, vim) and I can't. Some will do as you want, some just put the config file directly into the user directory.

But I agree with you, move the config file into the mozilla dedicated folder seems cleaner to me.

Comment 6

[Julien Pagès (:parkouss)]

With 0.42 release, we now warn the user to use a config file, and then we guide him to use a persist folder.

So I think this is good enough - please reopen the bug if I'm missing something!