error LNK2001: unresolved external symbol GetAsciiHostPort(class nsACString_internal &)

RESOLVED FIXED in Thunderbird 43.0

Status

MailNews Core
Backend
--
blocker
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Philip Chee, Assigned: Philip Chee)

Tracking

({dogfood})

Trunk
Thunderbird 43.0
dogfood

Firefox Tracking Flags

(firefox43 affected)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
nsLDAPURL.obj : error LNK2001: unresolved external symbol "public: virtual enum nsresult __stdcall nsLDAPURL::GetAsciiHo
stPort(class nsACString_internal &)" (?GetAsciiHostPort@nsLDAPURL@@UAG?AW4nsresult@@AAVnsACString_internal@@@Z)
nsAddbookUrl.obj : error LNK2001: unresolved external symbol "public: virtual enum nsresult __stdcall nsAddbookUrl::GetA
sciiHostPort(class nsACString_internal &)" (?GetAsciiHostPort@nsAddbookUrl@@UAG?AW4nsresult@@AAVnsACString_internal@@@Z)
nsPop3URL.obj : error LNK2001: unresolved external symbol "public: virtual enum nsresult __stdcall nsMsgMailNewsUrl::Get
AsciiHostPort(class nsACString_internal &)" (?GetAsciiHostPort@nsMsgMailNewsUrl@@UAG?AW4nsresult@@AAVnsACString_internal
@@@Z)
nsNntpUrl.obj : error LNK2001: unresolved external symbol "public: virtual enum nsresult __stdcall nsMsgMailNewsUrl::Get
AsciiHostPort(class nsACString_internal &)" (?GetAsciiHostPort@nsMsgMailNewsUrl@@UAG?AW4nsresult@@AAVnsACString_internal
@@@Z)
nsMsgMailNewsUrl.obj : error LNK2001: unresolved external symbol "public: virtual enum nsresult __stdcall nsMsgMailNewsU
rl::GetAsciiHostPort(class nsACString_internal &)" (?GetAsciiHostPort@nsMsgMailNewsUrl@@UAG?AW4nsresult@@AAVnsACString_i
nternal@@@Z)
nsSmtpUrl.obj : error LNK2001: unresolved external symbol "public: virtual enum nsresult __stdcall nsMsgMailNewsUrl::Get
AsciiHostPort(class nsACString_internal &)" (?GetAsciiHostPort@nsMsgMailNewsUrl@@UAG?AW4nsresult@@AAVnsACString_internal
@@@Z)
nsImapUrl.obj : error LNK2001: unresolved external symbol "public: virtual enum nsresult __stdcall nsMsgMailNewsUrl::Get
AsciiHostPort(class nsACString_internal &)" (?GetAsciiHostPort@nsMsgMailNewsUrl@@UAG?AW4nsresult@@AAVnsACString_internal
@@@Z)
nsMailboxUrl.obj : error LNK2001: unresolved external symbol "public: virtual enum nsresult __stdcall nsMsgMailNewsUrl::
GetAsciiHostPort(class nsACString_internal &)" (?GetAsciiHostPort@nsMsgMailNewsUrl@@UAG?AW4nsresult@@AAVnsACString_inter
nal@@@Z)
nsSmtpUrl.obj : error LNK2001: unresolved external symbol "public: virtual enum nsresult __stdcall nsMailtoUrl::GetAscii
HostPort(class nsACString_internal &)" (?GetAsciiHostPort@nsMailtoUrl@@UAG?AW4nsresult@@AAVnsACString_internal@@@Z)
xul.dll : fatal error LNK1120: 4 unresolved externals
c:/t1/hg/comm-central/mozilla/config/rules.mk:826: recipe for target 'xul.dll' failed

See Bug 1195415 - Use nsIURI.hostPort instead of manually writing host/port logic in nsPrincipal.origin logic
(Assignee)

Comment 1

2 years ago
Created attachment 8650107 [details] [diff] [review]
Patch v1.0 add method GetAsciiHostPort

Bustage fix
Assignee: nobody → philip.chee
Status: NEW → ASSIGNED
Attachment #8650107 - Flags: review?(Pidgeot18)
Comment on attachment 8650107 [details] [diff] [review]
Patch v1.0 add method GetAsciiHostPort

Review of attachment 8650107 [details] [diff] [review]:
-----------------------------------------------------------------

rs+

::: ldap/xpcom/src/nsLDAPURL.cpp
@@ +267,5 @@
> +
> +  return mBaseURL->GetAsciiHostPort(_retval);
> +}
> +
> +NS_IMETHODIMP 

ETRAILINGWHITESPACE.
Attachment #8650107 - Flags: review?(Pidgeot18) → review+
(Assignee)

Comment 3

2 years ago
(trailing whitespace removed on checkin)
https://hg.mozilla.org/comm-central/rev/670ecad50bcb
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Future
(Assignee)

Updated

2 years ago
Target Milestone: Future → Thunderbird 43.0

Updated

2 years ago
Severity: major → blocker
Keywords: dogfood
You need to log in before you can comment on or make changes to this bug.