make getChildCountCB work with proxies

RESOLVED FIXED in Firefox 43

Status

()

Core
Disability Access APIs
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: tbsaunde, Assigned: tbsaunde)

Tracking

(Blocks: 1 bug)

unspecified
mozilla43
Points:
---

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(2 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

2 years ago
Created attachment 8648898 [details] [diff] [review]
make getChildCountCB work with proxies
Attachment #8648898 - Flags: review?(dbolter)
Comment on attachment 8648898 [details] [diff] [review]
make getChildCountCB work with proxies

Review of attachment 8648898 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with note and nit.

::: accessible/atk/AccessibleWrap.cpp
@@ +830,5 @@
>      return static_cast<gint>(accWrap->EmbeddedChildCount());
> +  }
> +
> +  ProxyAccessible* proxy = GetProxy(aAtkObj);
> +  return proxy->MustPruneChildren() ? 0 : proxy->EmbeddedChildCount();

OK if you are sure that if GetAccessibleWrap fails means GetProxy will always succeed.

::: accessible/ipc/DocAccessibleChild.h
@@ +434,5 @@
>  
>    virtual bool RecvTakeFocus(const uint64_t& aID) override;
>  
> +  virtual bool RecvEmbeddedChildCount(const uint64_t& aID, uint32_t* aCount)
> +    override final;

Please a start new line for the second param (like surrounding method formats).
Attachment #8648898 - Flags: review?(dbolter) → review+
Assignee: nobody → tbsaunde+mozbugs
Blocks: 1029143
(Assignee)

Comment 3

2 years ago
(In reply to David Bolter [:davidb] from comment #2)
> Comment on attachment 8648898 [details] [diff] [review]
> make getChildCountCB work with proxies
> 
> Review of attachment 8648898 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me with note and nit.
> 
> ::: accessible/atk/AccessibleWrap.cpp
> @@ +830,5 @@
> >      return static_cast<gint>(accWrap->EmbeddedChildCount());
> > +  }
> > +
> > +  ProxyAccessible* proxy = GetProxy(aAtkObj);
> > +  return proxy->MustPruneChildren() ? 0 : proxy->EmbeddedChildCount();
> 
> OK if you are sure that if GetAccessibleWrap fails means GetProxy will
> always succeed.

err, that's a bug, but obviously returning 0 is what should happen if its null so I'll fix that

> 
> ::: accessible/ipc/DocAccessibleChild.h
> @@ +434,5 @@
> >  
> >    virtual bool RecvTakeFocus(const uint64_t& aID) override;
> >  
> > +  virtual bool RecvEmbeddedChildCount(const uint64_t& aID, uint32_t* aCount)
> > +    override final;
> 
> Please a start new line for the second param (like surrounding method
> formats).

I don't think that is the format? I'd say its put as much as possible on a line up to 80 chars then break reasonably as usual.  Though there is some stuff that seems to not follow that...

Comment 4

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/00d7cf364086
https://hg.mozilla.org/mozilla-central/rev/00d7cf364086
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
(Assignee)

Comment 6

2 years ago
Created attachment 8653104 [details] [diff] [review]
make getChildCountCB work with proxies
You need to log in before you can comment on or make changes to this bug.