1195609 - Async plugin init breaks Asperasoft Connect plugin

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[(No longer employed by Mozilla) Aaron Klotz]

https://bugzilla.mozilla.org/show_bug.cgi?id=1116806#c41

STR in:
https://bugzilla.mozilla.org/show_bug.cgi?id=1116806#c43

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Major regression and other plugins are affected, tracking.

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

When I run this plugin on a local build, the plugin container crashes on an assertion. It looks like the plugin is making calls into the browser outside of the plugin's main thread. NPAPI only supports calls made on the main thread.

I don't want to say that this is definitely the cause of the hang, but at the very least this should be fixed.

Comment 3

[akorchemniy]

Thanks. I'll investigate. Please share stack trace, plugin version if you can.

Comment 4

[(No longer employed by Mozilla) Aaron Klotz]

This is the stack trace that the assertion dumped on my Mac:

Assertion failure: IsPluginThread() (Should be on the plugin's main thread!), at ../../../dist/include/mozilla/plugins/PluginMessageUtils.h:203
#01: _ZN12_GLOBAL__N_115RequestCallback13returnMessageESs[/Users/dblohm7/Library/Internet Plug-Ins/Aspera Web 3.6.1.110647.plugin/Contents/MacOS/Aspera Web +0x960c]
#02: _ZN12_GLOBAL__N_115RequestCallback14handleCallbackEPv[/Users/dblohm7/Library/Internet Plug-Ins/Aspera Web 3.6.1.110647.plugin/Contents/MacOS/Aspera Web +0x94ec]
#03: _ZN7Connect3Web13RequestWorker17processOneRequestEv[/Users/dblohm7/Library/Internet Plug-Ins/Aspera Web 3.6.1.110647.plugin/Contents/MacOS/Aspera Web +0x32029]
#04: _ZN7Connect3Web13RequestWorker3runEv[/Users/dblohm7/Library/Internet Plug-Ins/Aspera Web 3.6.1.110647.plugin/Contents/MacOS/Aspera Web +0x31f36]
#05: start_helper[/Users/dblohm7/Library/Internet Plug-Ins/Aspera Web 3.6.1.110647.plugin/Contents/MacOS/Aspera Web +0x31642]
#06: _pthread_body[/usr/lib/system/libsystem_pthread.dylib +0x3268]
#07: _pthread_body[/usr/lib/system/libsystem_pthread.dylib +0x31e5]

Comment 5

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Aaron, I am following up on the FF41+ tracked bugs and wondering whether you believe there is a fix in the works? Do we have enough information or the investigation on this may go beyond 41 release and we might need to consider wontfix'ing this for 41? Thanks!

Comment 6

[(No longer employed by Mozilla) Aaron Klotz]

We're going to whitelist a set of mainstream plugins that are considered "safe" for async init. Once that lands we can resolve this as this particular plugin will no longer be affected.

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Given comment 6, and the fact that bug 1194488 was fixed, setting the status of this bug as resolved fixed.

Comment 8

[Petruta Horea [:phorea], Desktop QA]

mozilla / Mozilla1! login is no longer valid on https://faspex.com .

Akorchemniy, could you please reenable this account so that I can verify if it works. 

Or, if not, please confirm the fix using latest Nightly 43.0a1 build[1] or Firefox 41 beta 9 [2] when available.

[1] https://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-central/
[2] https://ftp.mozilla.org/pub/mozilla.org/firefox/candidates/41.0b9-candidates/build1/

Comment 9

[akorchemniy]

Previous account re-activated. I'll have our QA verify as well.

Comment 10

[Petruta Horea [:phorea], Desktop QA]

Thanks, I can log in now. 
I've tested under win 7 64-bit and Mac OS X 10.9.5.

While I don't reproduce the hang on Firefox 40.0RC, the plugin connects here and everything seems to work fine.

Using Firefox 41 beta 1 and Firefox 41 beta 9, I obtained the same results -> the plugin crashes and Aspera Connect doesn't launch.

Browser console error:
TypeError: a.httpRequestImplementation is not a function asperaweb-4.min.js:9:3033

The plugin crashes also when dom.ipc.plugins.asyncInit.enabled pref is set to false.

Aaron, any thoughts on this?

Comment 11

[(No longer employed by Mozilla) Aaron Klotz]

That's going to be the assertions in comment 2. The plugin is calling into the browser off the main thread which has never been supported in NPAPI. There were assertions added a while back to catch things like this, which must be what we're seeing (and is why we're seeing it when asyncInit is off as well).

TL;DR: Plugin bug, wontfix.

Comment 12

[Andrei Vaida [:avaida]]

Removing [qe-verify+] based on Comment 10 and Comment 11, there's nothing more manual QA can do here.

Comment 13

[akorchemniy]

Bug addressed in plugin.