1195931 - [e10s] Leading &nbsp; in <option> element inside a <select> is no longer rendered

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Stephen Clavering]

Attachment: select-indent-test.html

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:40.0) Gecko/20100101 Firefox/40.0
Build ID: 20150807085045

Steps to reproduce:

Load the attached testcase.  Click on the <select>.


Actual results:

The text of the second <option> element is displayed in line with that of the first one.


Expected results:

It should be displayed further to the right (due to the four leading non-breaking spaces).


This works fine in Firefox 40, and 41.0b1.  It's broken in 42.0a2 (2015-08-18) and Nightly 43.0a1 (2015-08-18).  I haven't tested earlier alpha/nightly versions.  I mostly tested on Mac OS, but also confirmed it's broken in Firefox 42.0a2 (2015-08-18) on Windows 7 too.

Comment 1

[Loic]

e10 issue. If you disable e10s, it works fine.

Comment 2

[Loic]

The bug occurs only with <select>, works fine with <datalist> in e10s mode.

data:text/html;charset=utf-8,<input list%3D"test"><datalist id%3D"test"><option>normal<%2Foption><option>%26nbsp%3B%26nbsp%3B%26nbsp%3B%26nbsp%3Bshould be indented<%2Foption><%2Fdatalist>

Comment 3

[Neil Deakin]

Attachment: Use option.text instead of option.textContent

This is consistent with what nsListControlFrame uses.

Comment 4

[Tracy Walker [:tracy]]

Putting in m8 bucket, since fix r+.

Comment 5

[Neil Deakin]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/cd22eb50ff2be11956a2298effa157850232fe2f
changeset:  cd22eb50ff2be11956a2298effa157850232fe2f
user:       Neil Deakin <[e-mail]>
date:       Fri Aug 21 13:30:04 2015 -0400
description:
Bug 1195931, use option.text instead of option.textContent so that spaces get handled properly in select lists, r=felipe

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cd22eb50ff2b