When loading about:privatebrowsing, we fail to update the title of the tab intermittently

VERIFIED FIXED in Firefox 42

Status

()

Firefox
Private Browsing
P1
normal
VERIFIED FIXED
3 years ago
2 years ago

People

(Reporter: Ehsan, Assigned: Paolo)

Tracking

({regression})

unspecified
Firefox 44
regression
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify +

Firefox Tracking Flags

(firefox41 unaffected, firefox42+ verified, firefox43 verified, firefox44 verified)

Details

(Whiteboard: [fxprivacy])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

3 years ago
Created attachment 8649474 [details]
Screenshot

STR:

Open a private window, and keep pressing Cmd+T to open several tabs.

You will see that some of those tabs will end up with a "New tab" title, but they've all loaded about:privatebrowsing.  See the screenshot.

Updated

3 years ago
Whiteboard: [fxprivacy] [triage]

Updated

3 years ago
Blocks: 1188565
Priority: -- → P2
Whiteboard: [fxprivacy] [triage] → [fxprivacy]
(Assignee)

Comment 1

3 years ago
Okay, so I tried removing all the Tracking Protection work from about:privatebrowsing by reverting only this page to revision 12cdd010b250, and the problem still persists, so this doesn't seem related to the changes made to the page.

If update the document title after a small timeout, this is reflected in the title of the tab. If I update the title immediately after the DOMContentLoaded or "load" events (even with a timeout of zero), the title is intermittently not updated in the tab (though the property of the document has the correct value).

This works fine on the current release channel, so we should find which recent revision introduced the race condition. This bug is easily reproducible using the steps in comment 0.
Keywords: regression, regressionwindow-wanted
[Tracking Requested - why for this release]:

Last good revision: f30e1413ebd1d845d7461dfc63bc35c7b627e359
First bad revision: 37bee149c935a35183f19d4a821fbf12549b8f88
Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=f30e1413ebd1d845d7461dfc63
bc35c7b627e359&tochange=37bee149c935a35183f19d4a821fbf12549b8f88

Regression from bug 1175812.
Blocks: 1175812
No longer blocks: 1190427
status-firefox41: --- → unaffected
status-firefox42: --- → affected
status-firefox43: --- → affected
tracking-firefox42: --- → ?
Keywords: regressionwindow-wanted
(Assignee)

Comment 3

3 years ago
Tim, it looks like you implemented preloading in bug 1077652. It seems that the issue of the title not updating intermittently is caused by enabling the preloading in attachment 8624045 [details] [diff] [review] from bug 1175812.

Do you know if this can be easily fixed in the preloading mechanism or with added code in the page, or maybe we should just disable preloading for this page? I think preloading for the simple about:privatebrowsing page is less important than for the about:newtab page.
Flags: needinfo?(ttaubert)
Visual issue on one of the key feature of 42. Tracking.
tracking-firefox42: ? → +
Preloading so far was only made for new tabs, and new tabs so far only had "New Tab" as their label. Here's where we set it:

http://hg.mozilla.org/mozilla-central/annotate/dd2a1d737a64/browser/base/content/tabbrowser.xml#l1860

The problem is that if we don't set it we would just end up with an empty label. Maybe we should try to get the label somehow from the preloaded content... which might be harder with e10s.
Flags: needinfo?(ttaubert)

Updated

2 years ago
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Iteration: --- → 44.1 - Oct 5
Flags: qe-verify?
Priority: P2 → P1
Hi Paolo, should this bug be marked for QE verification?
Flags: needinfo?(paolo.mozmail)
(Assignee)

Updated

2 years ago
Flags: qe-verify?
Flags: qe-verify+
Flags: needinfo?(paolo.mozmail)
(Assignee)

Comment 7

2 years ago
It seems the easiest solution is to disable preloading again for private windows - the issue in fact is not just with the title string, but with the tab icon as well. I think this can be safely uplifted to Beta as well.
(Assignee)

Comment 8

2 years ago
Created attachment 8668447 [details]
MozReview Request: Bug 1195981 - When loading about:privatebrowsing, we fail to update the title of the tab intermittently. r=ttaubert, bgrins

Bug 1195981 - When loading about:privatebrowsing, we fail to update the title of the tab intermittently. r=ttaubert
Attachment #8668447 - Flags: review?(ttaubert)
(Assignee)

Comment 9

2 years ago
Comment on attachment 8668447 [details]
MozReview Request: Bug 1195981 - When loading about:privatebrowsing, we fail to update the title of the tab intermittently. r=ttaubert, bgrins

Bug 1195981 - When loading about:privatebrowsing, we fail to update the title of the tab intermittently. r=ttaubert, bgrins
Attachment #8668447 - Attachment description: MozReview Request: Bug 1195981 - When loading about:privatebrowsing, we fail to update the title of the tab intermittently. r=ttaubert → MozReview Request: Bug 1195981 - When loading about:privatebrowsing, we fail to update the title of the tab intermittently. r=ttaubert, bgrins
Attachment #8668447 - Flags: review?(bgrinstead)
(Assignee)

Comment 10

2 years ago
Comment on attachment 8668447 [details]
MozReview Request: Bug 1195981 - When loading about:privatebrowsing, we fail to update the title of the tab intermittently. r=ttaubert, bgrins

Heh, ran "hg amend" on the wrong patch in the queue. Ignore the head.js file.
Attachment #8668447 - Flags: review?(bgrinstead)
Comment on attachment 8668447 [details]
MozReview Request: Bug 1195981 - When loading about:privatebrowsing, we fail to update the title of the tab intermittently. r=ttaubert, bgrins

https://reviewboard.mozilla.org/r/20961/#review18953
Attachment #8668447 - Flags: review?(ttaubert) → review+
https://hg.mozilla.org/mozilla-central/rev/bde12ec5cd8a
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox44: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 44
Hi Florin, can a QA contact be assigned.
Flags: needinfo?(florin.mezei)
Flags: needinfo?(florin.mezei)
QA Contact: petruta.rasa
(Assignee)

Comment 15

2 years ago
Comment on attachment 8668447 [details]
MozReview Request: Bug 1195981 - When loading about:privatebrowsing, we fail to update the title of the tab intermittently. r=ttaubert, bgrins

Approval Request Comment
[Feature/regressing bug #]: Bug 1175812
[User impact if declined]: Incorrect icon and label in newly opened tabs in private windows. Happens intermittently but frequently and quite noticeably in primary UI.
[Describe test coverage new/current, TreeHerder]: Landed on mozilla-central for some time
[Risks and why]: Basically reverts bug 1175812, which means we return to a previously tested situation. This limits risk.
[String/UUID change made/needed]: None
Attachment #8668447 - Flags: approval-mozilla-beta?
Attachment #8668447 - Flags: approval-mozilla-aurora?
Comment on attachment 8668447 [details]
MozReview Request: Bug 1195981 - When loading about:privatebrowsing, we fail to update the title of the tab intermittently. r=ttaubert, bgrins

Recent visual regression, taking it. Should be in 42 beta 5.
Attachment #8668447 - Flags: approval-mozilla-beta?
Attachment #8668447 - Flags: approval-mozilla-beta+
Attachment #8668447 - Flags: approval-mozilla-aurora?
Attachment #8668447 - Flags: approval-mozilla-aurora+
this failed to apply: 

Tomcats-MacBook-Pro-2:mozilla-central Tomcat$ hg graft --edit -r bde12ec5cd8a
grafting 306457:bde12ec5cd8a "Bug 1195981 - When loading about:privatebrowsing, we fail to update the title of the tab intermittently. r=ttaubert"
merging browser/base/content/tabbrowser.xml
warning: conflicts during merge.
merging browser/base/content/tabbrowser.xml incomplete! (edit conflicts, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use hg resolve and hg graft --continue)

could you take a look, thanks!
Flags: needinfo?(paolo.mozmail)
also re: comment #17 problem on aurora and beta
(Assignee)

Comment 19

2 years ago
https://hg.mozilla.org/releases/mozilla-aurora/rev/a895735dc414
https://hg.mozilla.org/releases/mozilla-beta/rev/3e8d02c81319
status-firefox42: affected → fixed
status-firefox43: affected → fixed
Flags: needinfo?(paolo.mozmail)
Verified as fixed using Firefox 42 beta 5, latest Aurora 43.0a2 and latest Nightly 44.0a1 2015-10-09 under win 7 64-bit and Mac OS X 10.9.5.
Status: RESOLVED → VERIFIED
status-firefox42: fixed → verified
status-firefox43: fixed → verified
status-firefox44: fixed → verified
You need to log in before you can comment on or make changes to this bug.