1195981 - When loading about:privatebrowsing, we fail to update the title of the tab intermittently

Status: VERIFIED FIXED

(Firefox :: Private Browsing, defect, P1)

Description

[(no longer active)]

Attachment: Screenshot

STR:

Open a private window, and keep pressing Cmd+T to open several tabs.

You will see that some of those tabs will end up with a "New tab" title, but they've all loaded about:privatebrowsing.  See the screenshot.

Comment 1

[:Paolo Amadini]

Okay, so I tried removing all the Tracking Protection work from about:privatebrowsing by reverting only this page to revision 12cdd010b250, and the problem still persists, so this doesn't seem related to the changes made to the page.

If update the document title after a small timeout, this is reflected in the title of the tab. If I update the title immediately after the DOMContentLoaded or "load" events (even with a timeout of zero), the title is intermittently not updated in the tab (though the property of the document has the correct value).

This works fine on the current release channel, so we should find which recent revision introduced the race condition. This bug is easily reproducible using the steps in comment 0.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

[Tracking Requested - why for this release]:

Last good revision: f30e1413ebd1d845d7461dfc63bc35c7b627e359
First bad revision: 37bee149c935a35183f19d4a821fbf12549b8f88
Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=f30e1413ebd1d845d7461dfc63
bc35c7b627e359&tochange=37bee149c935a35183f19d4a821fbf12549b8f88

Regression from bug 1175812.

Comment 3

[:Paolo Amadini]

Tim, it looks like you implemented preloading in bug 1077652. It seems that the issue of the title not updating intermittently is caused by enabling the preloading in attachment 8624045 [details] [diff] [review] from bug 1175812.

Do you know if this can be easily fixed in the preloading mechanism or with added code in the page, or maybe we should just disable preloading for this page? I think preloading for the simple about:privatebrowsing page is less important than for the about:newtab page.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Visual issue on one of the key feature of 42. Tracking.

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Preloading so far was only made for new tabs, and new tabs so far only had "New Tab" as their label. Here's where we set it:

http://hg.mozilla.org/mozilla-central/annotate/dd2a1d737a64/browser/base/content/tabbrowser.xml#l1860

The problem is that if we don't set it we would just end up with an empty label. Maybe we should try to get the label somehow from the preloaded content... which might be harder with e10s.

Comment 6

[Marco Mucci [:MarcoM]]

Hi Paolo, should this bug be marked for QE verification?

Comment 7

[:Paolo Amadini]

It seems the easiest solution is to disable preloading again for private windows - the issue in fact is not just with the title string, but with the tab icon as well. I think this can be safely uplifted to Beta as well.

Comment 8

[:Paolo Amadini]

Attachment: MozReview Request: Bug 1195981 - When loading about:privatebrowsing, we fail to update the title of the tab intermittently. r=ttaubert, bgrins

Bug 1195981 - When loading about:privatebrowsing, we fail to update the title of the tab intermittently. r=ttaubert

Comment 9

[:Paolo Amadini]

Comment on attachment 8668447 [details]
MozReview Request: Bug 1195981 - When loading about:privatebrowsing, we fail to update the title of the tab intermittently. r=ttaubert, bgrins

Bug 1195981 - When loading about:privatebrowsing, we fail to update the title of the tab intermittently. r=ttaubert, bgrins

Comment 10

[:Paolo Amadini]

Comment on attachment 8668447 [details]
MozReview Request: Bug 1195981 - When loading about:privatebrowsing, we fail to update the title of the tab intermittently. r=ttaubert, bgrins

Heh, ran "hg amend" on the wrong patch in the queue. Ignore the head.js file.

Comment 11

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8668447 [details]
MozReview Request: Bug 1195981 - When loading about:privatebrowsing, we fail to update the title of the tab intermittently. r=ttaubert, bgrins

https://reviewboard.mozilla.org/r/20961/#review18953

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/bde12ec5cd8a

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bde12ec5cd8a

Comment 14

[Marco Mucci [:MarcoM]]

Hi Florin, can a QA contact be assigned.

Comment 15

[:Paolo Amadini]

Comment on attachment 8668447 [details]
MozReview Request: Bug 1195981 - When loading about:privatebrowsing, we fail to update the title of the tab intermittently. r=ttaubert, bgrins

Approval Request Comment
[Feature/regressing bug #]: Bug 1175812
[User impact if declined]: Incorrect icon and label in newly opened tabs in private windows. Happens intermittently but frequently and quite noticeably in primary UI.
[Describe test coverage new/current, TreeHerder]: Landed on mozilla-central for some time
[Risks and why]: Basically reverts bug 1175812, which means we return to a previously tested situation. This limits risk.
[String/UUID change made/needed]: None

Comment 16

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8668447 [details]
MozReview Request: Bug 1195981 - When loading about:privatebrowsing, we fail to update the title of the tab intermittently. r=ttaubert, bgrins

Recent visual regression, taking it. Should be in 42 beta 5.

Comment 17

[Carsten Book [:Tomcat]]

this failed to apply: 

Tomcats-MacBook-Pro-2:mozilla-central Tomcat$ hg graft --edit -r bde12ec5cd8a
grafting 306457:bde12ec5cd8a "Bug 1195981 - When loading about:privatebrowsing, we fail to update the title of the tab intermittently. r=ttaubert"
merging browser/base/content/tabbrowser.xml
warning: conflicts during merge.
merging browser/base/content/tabbrowser.xml incomplete! (edit conflicts, then use 'hg resolve --mark')
abort: unresolved conflicts, can't continue
(use hg resolve and hg graft --continue)

could you take a look, thanks!

Comment 18

[Carsten Book [:Tomcat]]

also re: comment #17 problem on aurora and beta

Comment 19

[:Paolo Amadini]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a895735dc414
https://hg.mozilla.org/releases/mozilla-beta/rev/3e8d02c81319

Comment 20

[Petruta Horea [:phorea], Desktop Test Engineering]

Verified as fixed using Firefox 42 beta 5, latest Aurora 43.0a2 and latest Nightly 44.0a1 2015-10-09 under win 7 64-bit and Mac OS X 10.9.5.