1175812 - Use preloaded about:privatebrowsing page for private new tab pages

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[poiru]

Since bug 1077652, we preload about:privatebrowsing, but we never end up using it because of a check originally added for bug 799495.

Comment 1

[poiru]

Attachment: Use preloaded about:privatebrowsing page for private new tab pages

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6a0c6253edc0

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6a0c6253edc0

Comment 4

[poiru]

Comment on attachment 8624045 [details] [diff] [review]
Use preloaded about:privatebrowsing page for private new tab pages

Approval Request Comment
[Feature/regressing bug #]: Bug 1118285
[User impact if declined]: Flicker when opening new tab page in a private window. Prior to bug 1118285, one could manually set browser.newtab.url to e.g. about:blank to get rid of the flicker.
[Risks and why]: Minimal risk.
[String/UUID change made/needed]: No.

Comment 5

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8624045 [details] [diff] [review]
Use preloaded about:privatebrowsing page for private new tab pages

Approving for uplift to Aurora. This patch seems safe and has been in m-c for a while now so should be stable.

Comment 6

[Ryan VanderMeulen (PTO, back 6-April)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7bddb842cd1f

Comment 7

[Cody Crews]

Attachment: Screenshot from 2015-07-08 14:49:22.png

A screenshot showing that the new tab page is properly loading as about:privatebrowsing after this bug has been resolved.

Comment 8

[Cody Crews]

In the above the screenshot, I show that after visiting https://www.google.com in private browsing mode then pressing ctrl+t to open a new tab that the page shown is correct.

Comment 9

[Hossain Al Ikram [:ikram] (QA Contact)]

I was trying to test the fix but I am not able to see the bug. Can you please help me understand how I can see the issue so that this can be properly verified!!

I am seeing the same output in 40 beta and Nightly (from 2015-06-17 when the bug was filled) and also the latest one , Nightly 42.0a1! (On Windows 7 , 64 Bit)

Comment 10

[Cody Crews]

My understanding of this from looking at the patch was that it should already have a preloaded browser ready for entering into private browsing mode.  The patch takes away part of a conditional that leads to a call to _getPreloadedBrowser which should ensure that anytime you're entering into private browsing mode that this call is attempted.

I probably shouldn't have shown this with a screenshot, as you will get almost the same result visually either way.  That's my fault.  The screenshot does show that new tab page is in fact about:privatebrowsing but can't actually show that the call to _getPreloadedBrowser took place.  There's no real output or any way to show this off except for the fact that it doesn't break anything which is what I encountered here.

Any suggestions or anything different I should do here?

Comment 11

[poiru]

(In reply to Hossain Al Ikram [:ikram] (QA Contact) from comment #9)
> I was trying to test the fix but I am not able to see the bug. Can you
> please help me understand how I can see the issue so that this can be
> properly verified!

Try pressing CTRL+T multiple times in Beta. You should see a flicker as the background color changes from #fbfbfb to #ffffff and back. This happens very quickly so it's easy to miss.