1196067 - Upgrade bundleclone extension for SNI detection support so CloudFront works

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: CIDuty, task)

Description

[Gregory Szorc [:gps]]

+++ This bug was initially created as a clone of Bug #1144872 +++

In bug 1185261 we added support to the bundleclone extension to advertise and filter when SNI is required. This is needed to ensure clients on Python < 2.7.9 don't fail to fetch from CloudFront.

We should upgrade bundleclone in automation to get this feature.

This blocks advertising CloudFront as the primary bundle URL, which we want to do so people get the fastest download without any client-side configuration.

Comment 1

[Gregory Szorc [:gps]]

Attachment: Synchronize bundleclone with upstream for SNI support

File obtained from changeset 7f68be78132839ba05c58d0b07d32ed49368e2a6
of https://hg.mozilla.org/hgcustom/version-control-tools
file hgext/bundleclone/__init__.py and added unmodified.

Should be a rubber stamp review.

Comment 2

[(not currently active) Ted Mielczarek]

Presumably we'd ideally configure automation to prefer fetching from S3 (and from the S3 region that matches their region, if they're in EC2), right?

Comment 3

[Rail Aliiev [:rail]]

Comment on attachment 8649597 [details] [diff] [review]
Synchronize bundleclone with upstream for SNI support

lgtm

Comment 4

[Gregory Szorc [:gps]]

https://hg.mozilla.org/build/puppet/rev/b1861370abaf1af4ad51b2604310903006b3127d
Bug 1196067 - Synchronize bundleclone with upstream for SNI support; r=rail

Comment 5

[Gregory Szorc [:gps]]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2)
> Presumably we'd ideally configure automation to prefer fetching from S3 (and
> from the S3 region that matches their region, if they're in EC2), right?

This is already done. The plan is to have automation in EC2 prefer S3 from the local region and to use the default of the CDN everywhere else. In the future, we may change the server-side pieces to recognize client IPs inside EC2 and advertise URLs appropriately.

Comment 6

[Gregory Szorc [:gps]]

Not sure if I'm supposed to leave bug open or what. Setting needinfo so someone with knowledge can do the right thing.

Comment 7

[Rail Aliiev [:rail]]

We usually close bugs whenever they are landed. In this case the patch should be merged to production.

Comment 8

[Gregory Szorc [:gps]]

This has merged to production and is presumably deployed.