1196159 - [e10s] Window.closed returns false after calling Window.close()

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Xidorn Quan [:xidorn] UTC+10]

Attachment: testcase

Steps to reproduce:
1. open the testcase in the attachment;
2. click the button "Open Window and Close";
3. wait for 2 seconds

Expected result:
the popup window is closed, and a dialog shows "Is window closed? true"

Actual result:
the popup window is closed, but the dialog shows "Is window closed? false"

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

This blocks enabling Fullscreen API tests on e10s because the test fullscreen-api-race relies on this.

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

It seems we call preventDefault() in DOMWindowClose so that we do not have mIsClosed set immediately.

:billm, any thoughts about this bug?

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I guess this is actually a webcompat bug. Need to re-triage.

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

I'll wait for bug 967873 to land, since this will likely be related to that bug.

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bb7bdaace03f

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Proposed fix

Using preventDefault is using a very big hammer to avoid trying to close the actual window in the content process (especially because we send a message to the parent to do the actual closing). I thought about adding an API to tell the window that "yes, you're going to close" but that seems like overkill.

Of note here, once we send the DOMWindowClose message manager message, I don't think that the window *can't* close after that, so setting mIsClosed to true should be fine (thanks to bug 967873).

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4d8cadcfe408

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4d8cadcfe408

Comment 9

[Mike Conley (:mconley) (:⚙️)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c4196ff63838

Comment 10

[Mike Conley (:mconley) (:⚙️)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5091fd74dcfb

Comment 11

[Mike Conley (:mconley) (:⚙️)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d171061f7c7

Comment 12

[Mike Conley (:mconley) (:⚙️)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=54598564fc55

Comment 13

[Mike Conley (:mconley) (:⚙️)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a1b4345993db

Comment 14

[Mike Conley (:mconley) (:⚙️)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=995550437d31

Comment 15

[Mike Conley (:mconley) (:⚙️)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=567658f41a22