1196251 - Rename contacts_search_placesholder to reflect new string content

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Francesco Lodolo [:flod]]

Please do not change strings without updating the string ID.
https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings

Landing from bug 1183615
http://hg.mozilla.org/mozilla-central/diff/8b4784fd4c4d/browser/locales/en-US/chrome/browser/loop/loop.properties

Comment 1

[Andrei Oprea [:andreio]]

Attachment: Revert string change in Loop panel

Comment 2

[Francesco Lodolo [:flod]]

Comment on attachment 8649978 [details] [diff] [review]
Revert string change in Loop panel

Review of attachment 8649978 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/locales/en-US/chrome/browser/loop/loop.properties
@@ +85,5 @@
>  # Contact Strings (Panel)
>  
>  ## LOCALIZATION NOTE(contacts_search_placeholder): This is the placeholder text for
>  ## the search field.
> +contacts_search_placesholder=Search…

Sadly this doesn't work. Once the string landed on mozilla-central, any further change needs a new ID, even if you're going back to the previous value. 

We have no way to check who modified the string in the meantime, changing the ID is the only safe way.

Comment 3

[Andrei Oprea [:andreio]]

Attachment: Revert string change in Loop panel

Comment 4

[Francesco Lodolo [:flod]]

Comment on attachment 8650013 [details] [diff] [review]
Revert string change in Loop panel

Review of attachment 8650013 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thanks.

Comment 5

[Andrei Oprea [:andreio]]

https://hg.mozilla.org/integration/fx-team/rev/b7a37975cb98

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b7a37975cb98