Closed
Bug 1196360
Opened 10 years ago
Closed 8 years ago
Consolidate job_details lines into a shared partial
Categories
(Tree Management :: Treeherder: Frontend, defect, P4)
Tree Management
Treeherder: Frontend
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: jfrench, Unassigned)
Details
Begat from bug 1189498, it might be useful to consolidate this markup:
In the Job details tab
https://github.com/mozilla/treeherder/blob/29a704cc907ec8a64be02dc38d6bff5f555b5771/ui/plugins/job_details/main.html#L6-L11
And in the Logviewer
https://github.com/mozilla/treeherder/blob/29a704cc907ec8a64be02dc38d6bff5f555b5771/ui/plugins/job_details/main.html#L6-L11
into a single shared partial. We'd need to put an ng-if or similar condition in the partial on the Talos toggle so it's only triggered in Job Details.
Updated•8 years ago
|
Component: Treeherder → Treeherder: Frontend
Comment 1•8 years ago
|
||
Both the log viewer and the job details panel have been changed quite a bit since. Between that, the likely future churn of getting rid of a number of most TinderboxPrints and us eventually switching from Angular to React, I suspect there isn't much worth doing here now.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•