Log viewer does not display value of a 'text' content_type item from the job_details artifact

VERIFIED FIXED

Status

Tree Management
Treeherder: Log Viewer
P2
normal
VERIFIED FIXED
3 years ago
2 years ago

People

(Reporter: maja_zf, Assigned: jfrench)

Tracking

Details

(URL)

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
emorley
: review+
Details | Review | Splinter Review
(Reporter)

Description

3 years ago
All the job_details items are displayed correctly in the log viewer except for the second "artifact uploaded" item, which is:

{
   "content_type": "text",
   "value": "jenkins-mn-mse-youtube-medium1-60-nightly-win_32_64-62",
   "title": "artifact uploaded"
}

That is, the title is displayed in log viewer, but not the value.

The corresponding job_details artifact is here: https://treeherder.mozilla.org/api/project/mozilla-central/artifact/11231182/


(All the job details display correctly in the Job Details pane in the main Treeherder view.)

Comment 1

3 years ago
The logviewer URL in question:
https://treeherder.mozilla.org/logviewer.html#?job_id=1916933&repo=mozilla-central

Of all the artifacts listed for that job, it's the only one with a content_type of "text", the others are "link" or "raw_html".

The logviewer doesn't have a fallback for !link/raw_html:
https://github.com/mozilla/treeherder/blob/66ee095257552ba2c7b830eba408cb474094cd7b/ui/logviewer.html#L96-L100

Unlike the job details panel in the main UI:
https://github.com/mozilla/treeherder/blob/29a704cc907ec8a64be02dc38d6bff5f555b5771/ui/plugins/job_details/main.html#L5-L12

Ideally we'd also consolidate those two partials (we'd need to add support for toggling the talos specific behaviour beforehand).

:jfrench, up for tweaking that? :-)
Priority: -- → P2
(Assignee)

Comment 2

3 years ago
Sure thing :)
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
(Assignee)

Updated

3 years ago
Blocks: 1182178
(Assignee)

Comment 3

3 years ago
Created attachment 8649965 [details] [review]
PR 887

Tweak PR for review :) It now appears correctly with Maja's particular job.

I spoke with Ed on IRC and we agreed to consolidate the partials if possible, in a follow up.
Attachment #8649965 - Flags: review?(emorley)

Comment 4

3 years ago
Comment on attachment 8649965 [details] [review]
PR 887

Thanks :-)
Attachment #8649965 - Flags: review?(emorley) → review+
(Assignee)

Comment 5

3 years ago
Follow up for a consolidated partial is bug 1196360.

Comment 6

3 years ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/a4b0ae927ffaebb05679ddd5608660f2aa2c4b91
Bug 1189498 - Provide a text value fallback for logviewer job details
(Assignee)

Comment 7

3 years ago
Marking fixed per above merge. Will verify on the next push to stage/prod.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Comment 8

2 years ago
Verified fixed on production. eg.
https://treeherder.mozilla.org/logviewer.html#?job_id=2283038&repo=mozilla-central
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.