Closed
Bug 1189498
Opened 9 years ago
Closed 9 years ago
Log viewer does not display value of a 'text' content_type item from the job_details artifact
Categories
(Tree Management :: Treeherder, defect, P2)
Tree Management
Treeherder
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: impossibus, Assigned: jfrench)
References
()
Details
Attachments
(1 file)
All the job_details items are displayed correctly in the log viewer except for the second "artifact uploaded" item, which is: { "content_type": "text", "value": "jenkins-mn-mse-youtube-medium1-60-nightly-win_32_64-62", "title": "artifact uploaded" } That is, the title is displayed in log viewer, but not the value. The corresponding job_details artifact is here: https://treeherder.mozilla.org/api/project/mozilla-central/artifact/11231182/ (All the job details display correctly in the Job Details pane in the main Treeherder view.)
Comment 1•9 years ago
|
||
The logviewer URL in question: https://treeherder.mozilla.org/logviewer.html#?job_id=1916933&repo=mozilla-central Of all the artifacts listed for that job, it's the only one with a content_type of "text", the others are "link" or "raw_html". The logviewer doesn't have a fallback for !link/raw_html: https://github.com/mozilla/treeherder/blob/66ee095257552ba2c7b830eba408cb474094cd7b/ui/logviewer.html#L96-L100 Unlike the job details panel in the main UI: https://github.com/mozilla/treeherder/blob/29a704cc907ec8a64be02dc38d6bff5f555b5771/ui/plugins/job_details/main.html#L5-L12 Ideally we'd also consolidate those two partials (we'd need to add support for toggling the talos specific behaviour beforehand). :jfrench, up for tweaking that? :-)
Priority: -- → P2
Assignee | ||
Comment 3•9 years ago
|
||
Tweak PR for review :) It now appears correctly with Maja's particular job. I spoke with Ed on IRC and we agreed to consolidate the partials if possible, in a follow up.
Attachment #8649965 -
Flags: review?(emorley)
Comment 4•9 years ago
|
||
Comment on attachment 8649965 [details] [review] PR 887 Thanks :-)
Attachment #8649965 -
Flags: review?(emorley) → review+
Assignee | ||
Comment 5•9 years ago
|
||
Follow up for a consolidated partial is bug 1196360.
Comment 6•9 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/a4b0ae927ffaebb05679ddd5608660f2aa2c4b91 Bug 1189498 - Provide a text value fallback for logviewer job details
Assignee | ||
Comment 7•9 years ago
|
||
Marking fixed per above merge. Will verify on the next push to stage/prod.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 8•9 years ago
|
||
Verified fixed on production. eg. https://treeherder.mozilla.org/logviewer.html#?job_id=2283038&repo=mozilla-central
Status: RESOLVED → VERIFIED
Updated•2 years ago
|
Component: Treeherder: Log Viewer → TreeHerder
You need to log in
before you can comment on or make changes to this bug.
Description
•