1196373 - Beta version is missing from about:support and about Firefox

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

This is working with Desktop and the buildbot config seems correct.
http://hg.mozilla.org/build/buildbot-configs/file/a7dc6208111b/mozilla/release-fennec-mozilla-beta.py

Not sure what is wrong.

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: android-version.diff

Here is what was missing.

If I understand correctly http://hg.mozilla.org/build/buildbot-configs/file/a7dc6208111b/mozilla/release-fennec-mozilla-beta.py#l40, this file is also going to be updated the releng tools.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Nick, do you confirm that release-fennec-mozilla-beta.py will do the job?

Anyway, I rebuilt it and run it in an emulator and I confirm that the patch fixes the issue.

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 8659855 [details] [diff] [review]
android-version.diff

Review of attachment 8659855 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/confvars.sh
@@ +5,5 @@
>  MOZ_APP_BASENAME=Fennec
>  MOZ_APP_VENDOR=Mozilla
>  
>  MOZ_APP_VERSION=43.0a1
> +MOZ_APP_VERSION_DISPLAY=43.0a1

MOZ_APP_VERSION_DISPLAY defaults to MOZ_APP_VERSION when not given, so setting it to the same value is not doing anything useful. That said, I have no idea what the mentioned script does to this file, so...

Comment 4

[Nick Thomas [:nthomas] (UTC+12)]

In the objdir for the 41.0b10 api-9 build I grepped and found this:

config/autoconf.mk:MOZ_APP_VERSION = 41.0
config/autoconf.mk:MOZ_APP_VERSION_DISPLAY = 41.0

AIUI we want 41.0b10 there, like http://hg.mozilla.org/releases/mozilla-beta/rev/a1b015d51b73. aka the bumping is happening, but I'd guess browser/ isn't being read when we do an android build.

Comment 5

[Mike Hommey [:glandium]]

Which makes me think... why isn't mobile/android/confvars.sh just using the same as browser/confvars.sh?

  MOZ_APP_VERSION=$FIREFOX_VERSION
  MOZ_APP_VERSION_DISPLAY=$FIREFOX_VERSION_DISPLAY

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Attachment: android-beta-version.diff

Right, this patch should be much better.

Comment 7

[Mike Hommey [:glandium]]

Comment on attachment 8661131 [details] [diff] [review]
android-beta-version.diff

Review of attachment 8661131 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/confvars.sh
@@ +4,5 @@
>  
>  MOZ_APP_BASENAME=Fennec
>  MOZ_APP_VENDOR=Mozilla
>  
> +

unnecessary empty line.

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

rail, jlund - this probably has implications for the migration script.

Comment 9

[Rail Aliiev [:rail]]

(In reply to Nick Thomas [:nthomas] from comment #8)
> rail, jlund - this probably has implications for the migration script.

Is there anything that we need to bump during next merges? The patch actually removes a hardcoded value.

Comment 10

[Nick Thomas [:nthomas] (UTC+12)]

I think we'd no longer need to bump MOZ_APP_VERSION in mobile/android/confvars.sh, but would need to bump browser/config/{version,version_display}.txt. We need to finish that up in bug 1175331.

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/72fde1ca508a

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b2b73523df54

Comment 13

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8661131 [details] [diff] [review]
android-beta-version.diff

Approval Request Comment
[Feature/regressing bug #]: bug 1145175 (trying to get beta version displayed into the product)
[User impact if declined]: No beta version displayed (no big deal but this helps some users)
[Describe test coverage new/current, TreeHerder]: Local build
[Risks and why]: Low. Worst case scenario: the about window/about:support won't show any version.
[String/UUID change made/needed]: none

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/72fde1ca508a
https://hg.mozilla.org/mozilla-central/rev/b2b73523df54

Comment 15

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8661131 [details] [diff] [review]
android-beta-version.diff

Approved for uplift to aurora!

Comment 16

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8661131 [details] [diff] [review]
android-beta-version.diff

[Triage Comment]
For some reasons, this was not uplifted to aurora, updating the flags.

Comment 17

[Rail Aliiev [:rail]]

Comment on attachment 8661131 [details] [diff] [review]
android-beta-version.diff

https://hg.mozilla.org/releases/mozilla-beta/rev/11b976840f0f

Comment 18

[Nick Thomas [:nthomas] (UTC+12)]

Looks like the landing went a little wrong
http://hg.mozilla.org/releases/mozilla-beta/rev/11b976840f0f

The file contains this now:
     5 MOZ_APP_BASENAME=Fennec
     6 MOZ_APP_VENDOR=Mozilla
     7 
     8 +MOZ_APP_VERSION=$FIREFOX_VERSION
     9 +MOZ_APP_VERSION_DISPLAY=$FIREFOX_VERSION_DISPLAY
    10 MOZ_APP_UA_NAME=Firefox

Comment 19

[Nick Thomas [:nthomas] (UTC+12)]

Fixed with https://hg.mozilla.org/releases/mozilla-beta/rev/a4e929343997

Comment 20

[Rail Aliiev [:rail]]

(In reply to Nick Thomas [:nthomas] from comment #18)
> Looks like the landing went a little wrong
> http://hg.mozilla.org/releases/mozilla-beta/rev/11b976840f0f
> 
> The file contains this now:
>      5 MOZ_APP_BASENAME=Fennec
>      6 MOZ_APP_VENDOR=Mozilla
>      7 
>      8 +MOZ_APP_VERSION=$FIREFOX_VERSION
>      9 +MOZ_APP_VERSION_DISPLAY=$FIREFOX_VERSION_DISPLAY
>     10 MOZ_APP_UA_NAME=Firefox

D'oh... Sorry about that... My bad merging a failed patch... :/

Comment 21

[Flaviu Cos]

42.0b1 Version is displayed in about:support in Firefox 42 Beta 1.
Verified as fixed in Firefox 42 Beta 1.
Device Asus Transformer Pad (Android 4.2.1).

Comment 22

[Rail Aliiev [:rail]]

Woot!