1196386 - [Settings] Update add-on "Affected apps" logic to align with new matching scheme

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Michael Henretty [:mikehenrty][:mhenretty]]

Since the add-on API changed, the logic in the Settings app which determines which apps are "affected" needs to be updated. Here is the chrome spec which we will have to mimic in Settings:
https://developer.chrome.com/extensions/match_patterns

For reference, here is the Settings spec for add-ons:
https://bug1192026.bmoattachments.org/attachment.cgi?id=8646912

Comment 1

[Michael Henretty [:mikehenrty][:mhenretty]]

Yura, will you have some time to work on this?

Comment 2

[[:fabrice] Fabrice Desré]

Note that you can't get the content_scripts property from the app manifest anymore. You have to fetch $app_origin/manifest.json and get things from here.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] yzen:bug-1196386 > mozilla-b2g:master

Comment 4

[[e-mail]]

Comment on attachment 8655050 [details] [review]
[gaia] yzen:bug-1196386 > mozilla-b2g:master

Have no idea how to test this patch, but the syntax looks fine

Comment 5

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Fred Lin [:gasolin] from comment #4)
> Comment on attachment 8655050 [details] [review]
> [gaia] yzen:bug-1196386 > mozilla-b2g:master
> 
> Have no idea how to test this patch, but the syntax looks fine

Hey Fred, yes, unfortunately these new add-ons are not yet present (until the next foxfood update). Hopefully the test add-ons (manifests) help understanding the new format.

Comment 6

[Yura Zenevich [:yzen] (please use "needinfo")]

https://github.com/mozilla-b2g/gaia/commit/c0affa1c8d1f124fa38a3c98fecd9b9989ed2fb6