Closed Bug 1196386 Opened 5 years ago Closed 5 years ago

[Settings] Update add-on "Affected apps" logic to align with new matching scheme

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mikehenrty, Assigned: yzen)

References

Details

Attachments

(1 file)

Since the add-on API changed, the logic in the Settings app which determines which apps are "affected" needs to be updated. Here is the chrome spec which we will have to mimic in Settings:
https://developer.chrome.com/extensions/match_patterns

For reference, here is the Settings spec for add-ons:
https://bug1192026.bmoattachments.org/attachment.cgi?id=8646912
Yura, will you have some time to work on this?
Flags: needinfo?(yzenevich)
Note that you can't get the content_scripts property from the app manifest anymore. You have to fetch $app_origin/manifest.json and get things from here.
Assignee: nobody → yzenevich
Status: NEW → ASSIGNED
Flags: needinfo?(yzenevich)
Attachment #8655050 - Flags: review?(gasolin)
Comment on attachment 8655050 [details] [review]
[gaia] yzen:bug-1196386 > mozilla-b2g:master

Have no idea how to test this patch, but the syntax looks fine
Attachment #8655050 - Flags: review?(gasolin) → review+
(In reply to Fred Lin [:gasolin] from comment #4)
> Comment on attachment 8655050 [details] [review]
> [gaia] yzen:bug-1196386 > mozilla-b2g:master
> 
> Have no idea how to test this patch, but the syntax looks fine

Hey Fred, yes, unfortunately these new add-ons are not yet present (until the next foxfood update). Hopefully the test add-ons (manifests) help understanding the new format.
https://github.com/mozilla-b2g/gaia/commit/c0affa1c8d1f124fa38a3c98fecd9b9989ed2fb6
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Depends on: 1224985
Depends on: 1228587
You need to log in before you can comment on or make changes to this bug.