1196604 - Sibling selectors of #statusbar causes huge restyle

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Status bar, Utility tray, Notification, defect)

Description

[Ting-Yu Chou [:ting] (away)]

The sibling selectors [1] of #statusbar cause subtree restyle for all its later sibling (more than 30 and include #windows) when toggle maximized class.

This happens when launch application and takes long time on B2G process main thread, which easily delay sync IPC from child process.

[1] http://mxr.mozilla.org/gaia/source/apps/system/style/app_titlebar.css#65

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] janus926:bug-1196604.wip > mozilla-b2g:master

Comment 2

[Ting-Yu Chou [:ting] (away)]

Attachment: wip

Those selectors were created in bug 1047988, but the transition still works after removing them.

Comment 3

[Kevin Grandon :kgrandon]

Comment on attachment 8650246 [details] [review]
[gaia] janus926:bug-1196604.wip > mozilla-b2g:master

Seems to work fine. I think I'm ok with this as nothing broke. Thanks!

Comment 4

[Alberto Pastor [:albertopq]]

Comment on attachment 8650246 [details] [review]
[gaia] janus926:bug-1196604.wip > mozilla-b2g:master

Plenty of css code in that file is useless after bug 1177477.

I'm planning to clean it up in bug 1179723, so thank you for fixing this!

Comment 5

[Ting-Yu Chou [:ting] (away)]

Thank you ;)

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/4331bdd55414bc06e9d1b51fee7e94aad84c38c1