KidFox: Restricted profiles - Hide 'Remove' context menu item from Top Sites

VERIFIED FIXED in Firefox 42

Status

()

defect
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: csuciu, Assigned: sebastian)

Tracking

Trunk
Firefox 43
ARM
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 verified, firefox43 verified)

Details

Attachments

(1 attachment)

In a restricted profile, the 'Remove' context menu item from Top Sites should be hidden if the device owner enables 'Disable "Clear browsing history"'.

That's because removing an entry from Top Sites will also remove it from history
Assignee: nobody → s.kaspari
Status: NEW → ASSIGNED
Bug 1196708 - Restricted profiles: Hide Remove context menu item from Top Sites. r?mhaigh
Attachment #8653999 - Flags: review?(mhaigh)
Comment on attachment 8653999 [details]
MozReview Request: Bug 1196708 - Restricted profiles: Hide Remove context menu item from Top Sites. r?mhaigh

https://reviewboard.mozilla.org/r/17585/#review15993
Attachment #8653999 - Flags: review?(mhaigh) → review+
Comment on attachment 8653999 [details]
MozReview Request: Bug 1196708 - Restricted profiles: Hide Remove context menu item from Top Sites. r?mhaigh

Approval Request Comment
[Feature/regressing bug #]: Bug 1188905: KidFox: Restricted profiles - Prevent clearing history (KidFox is targeting Fx42)
[User impact if declined]: History can be cleared via removing top sites
[Describe test coverage new/current, TreeHerder]: Manual testing. No UI test support for restricted profiles yet.
[Risks and why]: Just hiding a context menu item. Very low risk.
[String/UUID change made/needed]: -
Attachment #8653999 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/ee9881d7a21c
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Verifying as fixed for the Top Sites grid, but 'Remove' is still available for the entries from the Top Sites list.
Should I fill a new bug for this?
Comment on attachment 8653999 [details]
MozReview Request: Bug 1196708 - Restricted profiles: Hide Remove context menu item from Top Sites. r?mhaigh

Polish of a new feature, taking it.
Attachment #8653999 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verifying as fixed for the Top Sites grid, but 'Remove' is still available for the entries from the Top Sites list.
Related to #1203011
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.