1196708 - KidFox: Restricted profiles - Hide 'Remove' context menu item from Top Sites

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Profile Handling, defect)

Description

[Catalin Suciu [:csuciu]]

In a restricted profile, the 'Remove' context menu item from Top Sites should be hidden if the device owner enables 'Disable "Clear browsing history"'.

That's because removing an entry from Top Sites will also remove it from history

Comment 1

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1196708 - Restricted profiles: Hide Remove context menu item from Top Sites. r?mhaigh

Bug 1196708 - Restricted profiles: Hide Remove context menu item from Top Sites. r?mhaigh

Comment 2

[Martyn Haigh (:mhaigh)]

Comment on attachment 8653999 [details]
MozReview Request: Bug 1196708 - Restricted profiles: Hide Remove context menu item from Top Sites. r?mhaigh

https://reviewboard.mozilla.org/r/17585/#review15993

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/ee9881d7a21c

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8653999 [details]
MozReview Request: Bug 1196708 - Restricted profiles: Hide Remove context menu item from Top Sites. r?mhaigh

Approval Request Comment
[Feature/regressing bug #]: Bug 1188905: KidFox: Restricted profiles - Prevent clearing history (KidFox is targeting Fx42)
[User impact if declined]: History can be cleared via removing top sites
[Describe test coverage new/current, TreeHerder]: Manual testing. No UI test support for restricted profiles yet.
[Risks and why]: Just hiding a context menu item. Very low risk.
[String/UUID change made/needed]: -

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ee9881d7a21c

Comment 6

[Catalin Suciu [:csuciu]]

Verifying as fixed for the Top Sites grid, but 'Remove' is still available for the entries from the Top Sites list.
Should I fill a new bug for this?

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8653999 [details]
MozReview Request: Bug 1196708 - Restricted profiles: Hide Remove context menu item from Top Sites. r?mhaigh

Polish of a new feature, taking it.

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/408b19349d5a

Comment 9

[u549602]

Verifying as fixed for the Top Sites grid, but 'Remove' is still available for the entries from the Top Sites list.
Related to #1203011