KidFox: Restricted profiles - Prevent clearing history

VERIFIED FIXED in Firefox 42

Status

()

defect
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: sebastian, Assigned: sebastian)

Tracking

42 Branch
Firefox 42
All
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 verified)

Details

Attachments

(1 attachment, 1 obsolete attachment)

We do not want the restricted user to clear the history (if denied by the device owner).

We already have bugs in place for removing the clear options from settings (bug 1125979, bug 1125980) but there are at least these additional places:

* "Clear browsing history" button at the bottom of the History panel
* "Remove" context menu item when long pressing an entry in the History panel
Posted patch 1188905-clear-history.patch (obsolete) — Splinter Review
Attachment #8640585 - Flags: review?(margaret.leibovic)
Depends on: 1187260
Comment on attachment 8640585 [details] [diff] [review]
1188905-clear-history.patch

Review of attachment 8640585 [details] [diff] [review]:
-----------------------------------------------------------------

I was going to ask a question about removing items form the recent tabs panel, but then I noticed we don't even have that capability! Maybe we should file a bug about that (totally out of scope from this issue :)

::: mobile/android/base/home/HistoryPanel.java
@@ +41,5 @@
>  import android.text.style.StyleSpan;
>  import android.text.style.UnderlineSpan;
>  import android.util.Log;
>  import android.util.SparseArray;
> +import android.view.*;

Nit: Don't use global imports.
Attachment #8640585 - Flags: review?(margaret.leibovic) → review+
Updated patch addressing the review comments.
Attachment #8640585 - Attachment is obsolete: true
Attachment #8641029 - Flags: review+
url:        https://hg.mozilla.org/integration/fx-team/rev/12855aeba4b75686e8772086994340a8cacae2a7
changeset:  12855aeba4b75686e8772086994340a8cacae2a7
user:       Sebastian Kaspari <s.kaspari@gmail.com>
date:       Fri Jul 31 09:59:01 2015 +0200
description:
Bug 1188905 - Restricted profiles: Prevent clearing history. r=margaret
https://hg.mozilla.org/mozilla-central/rev/12855aeba4b7
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42
Verified on Nightly and Aurora that "Clear browsing history" button from the history panel and "Remove" context menu item are not displayed in a restricted profile if "Disable 'Clear browsing history' option is enabled
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.