Closed Bug 1196834 Opened 6 years ago Closed 6 years ago

add a test for bug 1163570

Categories

(Core :: Plug-ins, defect)

42 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: jimm, Assigned: jimm)

References

(Depends on 1 open bug)

Details

Attachments

(1 file, 3 obsolete files)

No description provided.
hopefully this reproduces on our test hardware, we'll see.
Attached patch test patch v.1 (obsolete) — Splinter Review
Hmmph, doesn't appear to fail on our test hardware.
Attached patch test patch v.1 (obsolete) — Splinter Review
retriggers show this does fail, just not 100% of the time.

with the patch in bug 1163570:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=48beaf476817

without it:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4f8df2b58c62
Attachment #8651413 - Attachment is obsolete: true
Attached patch test patch v.1 (obsolete) — Splinter Review
Attachment #8651489 - Attachment is obsolete: true
Attached patch test patch v.1Splinter Review
follow up test for compositor plugin changes in bug 1163570.
Attachment #8651491 - Attachment is obsolete: true
Attachment #8651492 - Flags: review?(roc)
Comment on attachment 8651492 [details] [diff] [review]
test patch v.1

Review of attachment 8651492 [details] [diff] [review]:
-----------------------------------------------------------------

Wow, that was a mighty effort!
Attachment #8651492 - Flags: review?(roc) → review+
I should have set this to disabled on linux, the plugin helper isn't implemented there.
(In reply to Jim Mathies [:jimm] from comment #10)
> I should have set this to disabled on linux, the plugin helper isn't
> implemented there.

mcos too, even though we don't have e10s tests running there yet.
https://hg.mozilla.org/mozilla-central/rev/17576503a36b
Status: NEW → RESOLVED
Closed: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Depends on: 1249878
You need to log in before you can comment on or make changes to this bug.