1196953 - {ally} input element, type of "text", has no text in label.

Status: RESOLVED INVALID

(addons.mozilla.org Graveyard :: Code Quality, defect)

Description

[David Weir (satdav)]

Repair: Add text to the input element's associated label that describes the purpose or function of the control.
Error Line 76, Column 3:
<input id="search-q" type="text" name="q" autocomplete="off" title=""
         class="text placehold ...

Comment 1

[Mathieu Agopian [:magopian]]

I'm not sure I understand this bug: are you talking about the empty "title"?

Comment 2

[David Weir (satdav)]

http://achecker.ca/checker/index.php

I was using the stage url for this

Comment 3

[David Weir (satdav)]

(In reply to David Weir (satdav) from comment #0)
> Repair: Add text to the input element's associated label that describes the
> purpose or function of the control.
> Error Line 76, Column 3:
> <input id="search-q" type="text" name="q" autocomplete="off" title=""
>          class="text placehold ...

It looks like the search bar or the products drop down

Comment 4

[Victor Olasupo]

Is it okay for me to please have a go at this bug? As i can see it's assigned but has not been resolved ?

Comment 5

[Andre Klapper]

Victor: You can basically work on any bug that you want to. No need to ask for permission, and help (like code contributions) is always welcome. :)

Comment 6

[Victor Olasupo]

where is the location of this particular bugs code please ?

Comment 7

[Andy McKay]

Just so you know this code will be removed in the coming rewrite of addons.mozilla.org front end. That will be sometime in 2016, maybe 4-5 months from now. It would be awesome if you wanted to fix this bug, but I just want you to understand that it might not exist in the rewrite.

Comment 8

[Andy McKay]

(In reply to Victor Olasupo from comment #6)
> where is the location of this particular bugs code please ?

The code is in olympia:

https://github.com/mozilla/olympia/search?utf8=%E2%9C%93&q=search-q

You can find documentation on olympia at:

http://olympia.readthedocs.org/en/latest/

Comment 9

[David Weir (satdav)]

as was fixed with the code change