Open Bug 1197031 Opened 5 years ago Updated 2 years ago

Timeline breaks when no marker graph is used

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect, P3)

defect

Tracking

(Not tracked)

People

(Reporter: jsantell, Unassigned)

References

(Blocks 1 open bug)

Details

Right now we hardcode the feature of markers via "withMarkers" as always being true. There's a scenario where importing an older profile that does not have marker data, or if `withMarkers` was configurable, this breaks due to all graphs being linked to the marker graph.
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Depends on: 1171517
Right now the marker graph is the "main graph" -- with markers hidden, this isn't the case, and what if we don't have realtime markers, or using the old profiler backend, etc. -- I don't know that much about the graph linking, but in the scenario where we always create the marker graph (but hidden) to maintain the links, then we can't get `getMappedSelection` from the marker graph because it does not have any data.

What's the best way to solve this? Maybe a dummy graph that always exists that is the "primary link"?
Flags: needinfo?(vporof)
Have a dummy "time" graph that just tracks time.
Flags: needinfo?(vporof)
Assignee: jsantell → nobody
Status: ASSIGNED → NEW
Triaging. Filter on ADRENOCORTICOTROPIC (yes).
Priority: -- → P3
Version: 41 Branch → unspecified
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.