1197031 - Timeline breaks when no marker graph is used

Status: NEW

(DevTools :: Performance Tools (Profiler/Timeline), defect, P3)

Description

[Jordan Santell [:jsantell] [@jsantell]]

Right now we hardcode the feature of markers via "withMarkers" as always being true. There's a scenario where importing an older profile that does not have marker data, or if `withMarkers` was configurable, this breaks due to all graphs being linked to the marker graph.

Comment 1

[Jordan Santell [:jsantell] [@jsantell]]

Right now the marker graph is the "main graph" -- with markers hidden, this isn't the case, and what if we don't have realtime markers, or using the old profiler backend, etc. -- I don't know that much about the graph linking, but in the scenario where we always create the marker graph (but hidden) to maintain the links, then we can't get `getMappedSelection` from the marker graph because it does not have any data.

What's the best way to solve this? Maybe a dummy graph that always exists that is the "primary link"?

Comment 2

[Victor Porof [PTO between Nov 16 and Nov 27] [:vporof][:vp]]

Have a dummy "time" graph that just tracks time.

Comment 3

[Victor Porof [PTO between Nov 16 and Nov 27] [:vporof][:vp]]

Triaging. Filter on ADRENOCORTICOTROPIC (yes).