1197068 - CFNetwork.framework strings are not translated

Status: NEW

(Firefox for iOS :: Browser, defect)

Description

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

Attachment: photo_2015-08-21_00-04-47.jpg

In Bug 1196794 I noticed that we are not having error page for "too many HTTP redirects" localized. (see attachment)

The string comes from iOS directly and not localizable, we might need to check what happened and/or have it localizable on our own.

Comment 1

[Aaron Train [:aaronmt]]

This should probably be morphed/checked to see if error codes can/may be translatable. Stephan?


If it's just a missing translation for this particular locale we can move this bug to Mozilla Localizations.

Comment 2

[Stephan Leroux [:sleroux]]

The unlocalized title is coming from the HTTP error and we don't bind the title of the error to our localized strings files. We need to add map an entry from our localized strings to the error's NSLocalizedDescriptionKey using NSError's userInfo property: http://nshipster.com/nserror/ (a bit down the page).

So this is two parts:

1. Engineering work to add in the mappings to expose these error strings to localizers
2. Localize the missing network errors

Comment 3

[Johannes Marbach]

Just curious, but does overriding the translation really work here? The value stored under NSLocalizedDescriptionKey in the userInfo dictionary should already be translated. Because of this, I had assumed the translation look-up to be performed at the time the NSError is created which happens inside of CFNetwork using the CFNetwork string resources. Shouldn't that look-up completely ignore any translations we add to the main bundle?

These are the strings I was able to grep from the CFNetwork resources:

$ find /System/Library/Frameworks/CFNetwork.framework/Resources/ -name *.lproj -exec ls {}/Localizable.strings \; -exec cp {}/Localizable.strings ~/Desktop \; -exec plutil -convert xml1 ~/Desktop/Localizable.strings \; -exec grep -A 1 "Err-1007" ~/Desktop/Localizable.strings \;

/System/Library/Frameworks/CFNetwork.framework/Resources//ar.lproj/Localizable.strings
	<key>Err-1007</key>
	<string>يوجد الكثير من عمليات إعادة توجيه HTTP</string>
/System/Library/Frameworks/CFNetwork.framework/Resources//ca.lproj/Localizable.strings
	<key>Err-1007</key>
	<string>massa redireccionaments HTTP</string>
/System/Library/Frameworks/CFNetwork.framework/Resources//cs.lproj/Localizable.strings
	<key>Err-1007</key>
	<string>příliš mnoho přesměrování HTTP</string>
/System/Library/Frameworks/CFNetwork.framework/Resources//da.lproj/Localizable.strings
	<key>Err-1007</key>
	<string>for mange HTTP-omdirigeringer</string>
/System/Library/Frameworks/CFNetwork.framework/Resources//Dutch.lproj/Localizable.strings
	<key>Err-1007</key>
	<string>te veel HTTP-omleidingen</string>
/System/Library/Frameworks/CFNetwork.framework/Resources//el.lproj/Localizable.strings
	<key>Err-1007</key>
	<string>πάρα πολλές ανακατευθύνσεις HTTP</string>
/System/Library/Frameworks/CFNetwork.framework/Resources//English.lproj/Localizable.strings
	<key>Err-1007</key>
	<string>too many HTTP redirects</string>
/System/Library/Frameworks/CFNetwork.framework/Resources//es_MX.lproj/Localizable.strings
	<key>Err-1007</key>
	<string>demasiados redireccionamientos HTTP</string>
/System/Library/Frameworks/CFNetwork.framework/Resources//fi.lproj/Localizable.strings
	<key>Err-1007</key>
	<string>liikaa HTTP-uudelleenohjauksia</string>
/System/Library/Frameworks/CFNetwork.framework/Resources//French.lproj/Localizable.strings
	<key>Err-1007</key>
	<string>trop de redirections HTTP</string>
/System/Library/Frameworks/CFNetwork.framework/Resources//German.lproj/Localizable.strings
	<key>Err-1007</key>
	<string>Zu viele HTTP-Umleitungen</string>
/System/Library/Frameworks/CFNetwork.framework/Resources//he.lproj/Localizable.strings
	<key>Err-1007</key>
	<string>יותר מדי הפניות של HTTP</string>
/System/Library/Frameworks/CFNetwork.framework/Resources//hr.lproj/Localizable.strings
	<key>Err-1007</key>
	<string>previše preusmjeravanja HTTP protokola</string>
/System/Library/Frameworks/CFNetwork.framework/Resources//hu.lproj/Localizable.strings
	<key>Err-1007</key>
	<string>túl sok HTTP átirányítás</string>
/System/Library/Frameworks/CFNetwork.framework/Resources//id.lproj/Localizable.strings
	<key>Err-1007</key>
	<string>terlalu banyak pengalihan HTTP</string>
/System/Library/Frameworks/CFNetwork.framework/Resources//Italian.lproj/Localizable.strings
	<key>Err-1007</key>
	<string>troppi HTTP ridiretti</string>
/System/Library/Frameworks/CFNetwork.framework/Resources//Japanese.lproj/Localizable.strings
	<key>Err-1007</key>
	<string>HTTP のリダイレクトが多すぎます</string>
/System/Library/Frameworks/CFNetwork.framework/Resources//ko.lproj/Localizable.strings
	<key>Err-1007</key>
	<string>HTTP 재이동이 너무 많음</string>
/System/Library/Frameworks/CFNetwork.framework/Resources//ms.lproj/Localizable.strings
	<key>Err-1007</key>
	<string>terlalu banyak ubah hala HTTP</string>
/System/Library/Frameworks/CFNetwork.framework/Resources//no.lproj/Localizable.strings
	<key>Err-1007</key>
	<string>for mange HTTP-omdirigeringer</string>
/System/Library/Frameworks/CFNetwork.framework/Resources//pl.lproj/Localizable.strings
	<key>Err-1007</key>
	<string>zbyt wiele przekierowań HTTP</string>
/System/Library/Frameworks/CFNetwork.framework/Resources//pt.lproj/Localizable.strings
	<key>Err-1007</key>
	<string>demasiados redirecionamentos de HTTP</string>
/System/Library/Frameworks/CFNetwork.framework/Resources//pt_PT.lproj/Localizable.strings
	<key>Err-1007</key>
	<string>demasiados redireccionamentos HTTP</string>
/System/Library/Frameworks/CFNetwork.framework/Resources//ro.lproj/Localizable.strings
	<key>Err-1007</key>
	<string>prea multe redirecționări HTTP</string>
/System/Library/Frameworks/CFNetwork.framework/Resources//ru.lproj/Localizable.strings
	<key>Err-1007</key>
	<string>слишком много переадресовок HTTP</string>
/System/Library/Frameworks/CFNetwork.framework/Resources//sk.lproj/Localizable.strings
	<key>Err-1007</key>
	<string>príliš veľa presmerovaní HTTP</string>
/System/Library/Frameworks/CFNetwork.framework/Resources//Spanish.lproj/Localizable.strings
	<key>Err-1007</key>
	<string>demasiados redireccionamientos HTTP</string>
/System/Library/Frameworks/CFNetwork.framework/Resources//sv.lproj/Localizable.strings
	<key>Err-1007</key>
	<string>för många HTTP-omdirigeringar</string>
/System/Library/Frameworks/CFNetwork.framework/Resources//th.lproj/Localizable.strings
	<key>Err-1007</key>
	<string>มีการเปลี่ยนเส้นทาง HTTP มากเกินไป</string>
/System/Library/Frameworks/CFNetwork.framework/Resources//tr.lproj/Localizable.strings
	<key>Err-1007</key>
	<string>çok fazla HTTP yönlendirmesi</string>
/System/Library/Frameworks/CFNetwork.framework/Resources//uk.lproj/Localizable.strings
	<key>Err-1007</key>
	<string>забагато переадресувань HTTP</string>
/System/Library/Frameworks/CFNetwork.framework/Resources//vi.lproj/Localizable.strings
	<key>Err-1007</key>
	<string>quá nhiều chuyển hướng HTTP</string>
/System/Library/Frameworks/CFNetwork.framework/Resources//zh_CN.lproj/Localizable.strings
	<key>Err-1007</key>
	<string>太多的 HTTP 重定向</string>
/System/Library/Frameworks/CFNetwork.framework/Resources//zh_TW.lproj/Localizable.strings
	<key>Err-1007</key>
	<string>太多 HTTP 轉址</string>

All of these should (theoretically) show up as long as the app is configured to be localizable in the respective locale. I'm not sure how this is handled in Firefox on iOS though because the project file only lists English as the development language and no translations.

Peter, what is the locale in which the screenshot was taken?

Comment 4

[Peter Pin-Guang Chen [:petercpg] (MozTW.org)]

The screenshot was taken in zh-TW, I didn't test in in other locales listed above.

Comment 6

[Aaron Train [:aaronmt]]

Re-summarize this better if need be

Comment 7

[Aaron Train [:aaronmt]]

From the duplicate report; strings shown in English with device set as `pl`

Error-1200, should be: 

/System/Library/Frameworks/CFNetwork.framework/Resources//pl.lproj/Localizable.strings
	<key>Err-1200</key>
	<string>Wystąpił błąd SSL i nie można ustanowić bezpiecznego połączenia z serwerem.</string>
/System/Library/Frameworks/CFNetwork.framework/Resources//pt.lproj/Localizable.strings