1197075 - Do not continuously decode video.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Jean-Yves Avenard [:jya]]

Bug 1171257 introduced a work around where it was found that 4K decoding was too slow on the aries.

This however introduced several problems such as video queues becoming too big in the decoder or in the reader.

This change should be reverted, and proper profiling should be performed to understand exctly where the bottleneck is and so a proper fix can be done rather than a work around.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: P1. Revert "Bug 1197051 - Don't try to decode ahead while seeking

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: P2 Revert "Bug 1171257 - Add force decode ahead to MediaFormatReader

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: P3. Decode frames ahead of MDSM requesting them.

Comment 4

[Jean-Yves Avenard [:jya]]

Comment on attachment 8651611 [details] [diff] [review]
P3. Decode frames ahead of MDSM requesting them.

This causes intermittent EME failure when we attempt to decode data before the CDMWrapper is ready.

Will rework to only start decoding once Request*Data has been received.

Comment 5

[Jean-Yves Avenard [:jya]]

Attachment: P3. Decode frames ahead of MDSM requesting them.

This makes the media.*-decode-ahead pref performs more according to its name.
We decode audio and video in advance so a MediaDataPromise can be resolved almost instantly.
Default is 2.

Comment 6

[Jean-Yves Avenard [:jya]]

Attachment: P4. Reject skip promise on cancellation or shutdown.

Also remove redundant code.

Comment 7

[Jean-Yves Avenard [:jya]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c661ca5624c0

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e6b24f3de23f
https://hg.mozilla.org/integration/mozilla-inbound/rev/83fc1d3d82bd
https://hg.mozilla.org/integration/mozilla-inbound/rev/06df6f042656
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b1e524fee81

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e6b24f3de23f
https://hg.mozilla.org/mozilla-central/rev/83fc1d3d82bd
https://hg.mozilla.org/mozilla-central/rev/06df6f042656
https://hg.mozilla.org/mozilla-central/rev/2b1e524fee81

Comment 10

[Ralph Giles (:rillian)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a21aa658533c

Comment 11

[Ralph Giles (:rillian)]

Backed out for a youtube playback regression. See Bug 1199573.
https://hg.mozilla.org/releases/mozilla-aurora/rev/5bb661db5c6c

Comment 12

[Jean-Yves Avenard [:jya]]

pushed it as part of 
https://hg.mozilla.org/releases/mozilla-aurora/pushloghtml?changeset=7437f28133fc