Do not continuously decode video.

RESOLVED FIXED in Firefox 42

Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jya, Assigned: jya)

Tracking

(Blocks 1 bug)

Trunk
mozilla43
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 fixed, firefox43 fixed)

Details

Attachments

(4 attachments, 1 obsolete attachment)

Bug 1171257 introduced a work around where it was found that 4K decoding was too slow on the aries.

This however introduced several problems such as video queues becoming too big in the decoder or in the reader.

This change should be reverted, and proper profiling should be performed to understand exctly where the bottleneck is and so a proper fix can be done rather than a work around.
Blocks: EME
Blocks: 1197083
Assignee: nobody → jyavenard
Attachment #8651611 - Flags: review?(edwin)
Attachment #8651609 - Attachment description: Revert-Bug-1197051-Don-t-try-to-deco.patch → P1. Revert "Bug 1197051 - Don't try to decode ahead while seeking
Depends on: 1198094
Comment on attachment 8651611 [details] [diff] [review]
P3. Decode frames ahead of MDSM requesting them.

This causes intermittent EME failure when we attempt to decode data before the CDMWrapper is ready.

Will rework to only start decoding once Request*Data has been received.
Attachment #8651611 - Attachment is obsolete: true
Attachment #8651611 - Flags: review?(edwin)
This makes the media.*-decode-ahead pref performs more according to its name.
We decode audio and video in advance so a MediaDataPromise can be resolved almost instantly.
Default is 2.
Attachment #8652641 - Flags: review?(edwin)
Also remove redundant code.
Attachment #8652642 - Flags: review?(edwin)
Backed out for a youtube playback regression. See Bug 1199573.
https://hg.mozilla.org/releases/mozilla-aurora/rev/5bb661db5c6c
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Blocks: 1199904
You need to log in before you can comment on or make changes to this bug.