Do not continuously decode video.

RESOLVED FIXED in Firefox 42

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jya, Assigned: jya)

Tracking

(Blocks: 1 bug)

Trunk
mozilla43
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox42 fixed, firefox43 fixed)

Details

Attachments

(4 attachments, 1 obsolete attachment)

(Assignee)

Description

3 years ago
Bug 1171257 introduced a work around where it was found that 4K decoding was too slow on the aries.

This however introduced several problems such as video queues becoming too big in the decoder or in the reader.

This change should be reverted, and proper profiling should be performed to understand exctly where the bottleneck is and so a proper fix can be done rather than a work around.
(Assignee)

Updated

3 years ago
Blocks: 1015800
(Assignee)

Updated

3 years ago
Blocks: 1197083
(Assignee)

Comment 1

3 years ago
Created attachment 8651609 [details] [diff] [review]
P1. Revert "Bug 1197051 - Don't try to decode ahead while seeking
Attachment #8651609 - Flags: review?(edwin)
(Assignee)

Updated

3 years ago
Assignee: nobody → jyavenard
(Assignee)

Comment 2

3 years ago
Created attachment 8651610 [details] [diff] [review]
P2 Revert "Bug 1171257 - Add force decode ahead to MediaFormatReader
Attachment #8651610 - Flags: review?(edwin)
(Assignee)

Comment 3

3 years ago
Created attachment 8651611 [details] [diff] [review]
P3. Decode frames ahead of MDSM requesting them.
Attachment #8651611 - Flags: review?(edwin)
(Assignee)

Updated

3 years ago
Attachment #8651609 - Attachment description: Revert-Bug-1197051-Don-t-try-to-deco.patch → P1. Revert "Bug 1197051 - Don't try to decode ahead while seeking
(Assignee)

Updated

3 years ago
Depends on: 1198094
(Assignee)

Comment 4

3 years ago
Comment on attachment 8651611 [details] [diff] [review]
P3. Decode frames ahead of MDSM requesting them.

This causes intermittent EME failure when we attempt to decode data before the CDMWrapper is ready.

Will rework to only start decoding once Request*Data has been received.
Attachment #8651611 - Attachment is obsolete: true
Attachment #8651611 - Flags: review?(edwin)
(Assignee)

Comment 5

3 years ago
Created attachment 8652641 [details] [diff] [review]
P3. Decode frames ahead of MDSM requesting them.

This makes the media.*-decode-ahead pref performs more according to its name.
We decode audio and video in advance so a MediaDataPromise can be resolved almost instantly.
Default is 2.
Attachment #8652641 - Flags: review?(edwin)
(Assignee)

Comment 6

3 years ago
Created attachment 8652642 [details] [diff] [review]
P4. Reject skip promise on cancellation or shutdown.

Also remove redundant code.
Attachment #8652642 - Flags: review?(edwin)
Backed out for a youtube playback regression. See Bug 1199573.
https://hg.mozilla.org/releases/mozilla-aurora/rev/5bb661db5c6c
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → RESOLVED
Last Resolved: 3 years ago3 years ago
status-firefox42: fixed → affected
Resolution: --- → FIXED
(Assignee)

Updated

3 years ago
Blocks: 1199904
(Assignee)

Comment 12

3 years ago
pushed it as part of 
https://hg.mozilla.org/releases/mozilla-aurora/pushloghtml?changeset=7437f28133fc
status-firefox42: affected → fixed
You need to log in before you can comment on or make changes to this bug.