1197125 - WebMDemuxer will read the entire webm into memory if the file is local

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[Jean-Yves Avenard [:jya]]

Noticed this problem when reviewing why bug 1195073 was failing on linux.

WebMDemuxer::EnsureUpToDateIndex will call MediaResource::GetCachedRanges() retrieve the array of byte ranges and call WebMBufferedState::WebMBufferedState::UpdateIndex()

this will call MediaResource::MediaReadAt() and read the entire byte range.

However, for local files, the cache byte range is always the entire file.

As such, the entire file will first be read into memory, and then parsed.

So to play a local file, we will potentially allocate a very big array. This will also limit us to play 2GiB files only as a nsTArray can't hold more than 2GiB

Reads should be made using partial blocks, to ensure we allocate too much RAM at once.

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: [webm]. Don't load the entire webm in RAM.

Instead we parse it in chunks of 1MiB max.

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/df3b5b643439

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/df3b5b643439

Comment 4

[Ralph Giles (:rillian)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6c48368813f8

Comment 5

[Ralph Giles (:rillian)]

Backed out for a youtube playback regression. See Bug 1199573.
https://hg.mozilla.org/releases/mozilla-aurora/rev/5bb661db5c6c

Comment 6

[Jean-Yves Avenard [:jya]]

pushed it as part of 
https://hg.mozilla.org/releases/mozilla-aurora/pushloghtml?changeset=7437f28133fc