1197191 - Add .pdf and media file types to OpenWithProgids

Status: RESOLVED FIXED

(Firefox :: Installer, defect)

Description

[Masatoshi Kimura [:emk]]

Steps to reproduce:
1. If you are using Windows 7, install Acrobat Reader (or another PDF viewer).
2. Install Firefox.
3. Right click a PDF file to open the context menu.

Actual result:
Firefox is not listed in "Open With" menu.

Expected result:
Firefox should be listed in "Open With" menu.

On Windows 8, the "Reader" app was the default .pdf handler. On Windows 10, Microsoft Edge is the default .pdf handler. So Firefox will never add an association for .pdf on Win8+.

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: patch

Comment 2

[Masatoshi Kimura [:emk]]

Review ping

Comment 3

[Robert Strong (they/them - no direct email)]

The ability to use Firefox to read pdf files was specifically added for systems that don't already have a pdf reader. There have been a few complaints about our pdf reader in the past so I'm hesitant to make Firefox an option in open with for pdf files. I'll cc shorlander and Philipp to find someone from UX to make the call.

Also, if this were to be done I'm really tempted to only add this to HKLM since it is possible someone that won't perform the uninstall can end up with these keys being left behind. I know that there are other keys that can be left behind as well but I try to keep that to a minimum.

Comment 4

[Robert Strong (they/them - no direct email)]

Stephen / Philipp: can you or someone on one of your teams make the call as to whether we should offer Firefox as an alternate pdf file reader when the user already has a pdf reader? I have had complaints about even adding Firefox as the pdf reader when there are no other pdf readers and iirc this was due to our reader implementation not always working 100%.

Comment 5

[Robert Strong (they/them - no direct email)]

Comment on attachment 8651005 [details] [diff] [review]
patch

Cancelling request. If UX provides feedback to go ahead with this please re-request

Comment 6

[Stephen Horlander [:shorlander]]

Just to clarify: Are we talking about making Firefox the *default* PDF handler? Or just adding it as an option?

Comment 7

[Robert Strong (they/them - no direct email)]

Adding it as an option under open with. We only add ourselves as the default handler if there is no pdf handler. I do question the value to maintenance tradeoff of adding this for things like pdf's and chrome and ie both don't do this.

Comment 8

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

I'm inclined to include it at least on Windows 10, because your default way of viewing PDFs there is Edge. If someone is switching to Firefox because they don't want Edge, they'll still get that browser when viewing PDFs.

Note that we shouldn't make Firefox the default PDF viewer, even when a user opts into setting Firefox as their default browser. It's a different choice.

Comment 9

[Robert Strong (they/them - no direct email)]

If it is added for Win10 then let's do this everywhere to simplify the code paths.

Comment 10

[Masatoshi Kimura [:emk]]

Comment on attachment 8651005 [details] [diff] [review]
patch

Re-requesting review per comment #8.

(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #3)
> Also, if this were to be done I'm really tempted to only add this to HKLM
> since it is possible someone that won't perform the uninstall can end up
> with these keys being left behind. I know that there are other keys that can
> be left behind as well but I try to keep that to a minimum.

It was impossible at least on Windows 10. We don't add file handlers to the registry on install. Instead, firefox.exe will call helper when the user pressed [Set As Default] button. So we have no admin privilege at that point.

Moreover, it will not work for standard (non-admin) users.

Comment 11

[Masatoshi Kimura [:emk]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cf9c24d98972

Comment 12

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5998e5f18e579167ccf86f068bd265e819f62f7f
Bug 1197191 - Add .pdf and media file types to OpenWithProgids. r=rstrong

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5998e5f18e57

Comment 15

[Mayur Patil]

[bugday-20160323]

Status: RESOLVED,FIXED -> VERIFIED

Comments:
STR: clear.
test successful.

Component: 
Name 			Firefox
Version 		46.0b4
Build ID 		20160322075646
Update Channel 	        beta
User Agent 		Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0
OS                      Windows 7 SP1 x86_64

Expected Results: 
Firefox is appearing in open with.

Actual Results: 
As expected