1197529 - Janky map panning on carto.com

Status: NEW

(Core :: Layout, defect, P3)

Description

[Mikel]

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:43.0) Gecko/20100101 Firefox/43.0
Build ID: 20150822030206

Steps to reproduce:

1) Enter https://tecnilogica.cartodb.com/viz/56e702fe-4693-11e5-8f79-0e853d047bba/embed_map
2) Start zooming and panning
3) Observe the jank (especially when fling panning fast to one of the sides).


Actual results:

Jank when interacting with the map.


Expected results:

No jank when interacting with the map.

Comment 1

[Markus Stange [:mstange]]

The whole map is invalidated on every move. I don't see why at the moment. The map is moved using a CSS transform, which is exactly the right thing to do here.

Comment 2

[Mikel]

Still an issue after 2 years :(

Comment 3

[Mikel]

The URL in the OP isn't valid anymore,
Here is a new one:
https://telegraphtravel.carto.com/viz/7c64c57a-ce82-11e6-bd0a-0e8c56e2ffdb/embed_map

It's still somewhat janky on the latest Nightly.

Comment 4

[Mikel]

A better URL (from the same site) which exhibit the issue:
https://fee.carto.com/viz/6ed46582-5aed-11e5-9391-0e9d821ea90d/embed_map?wmode=opaque

Comment 5

[Mikel]

Still Junky..

Comment 6

[Sean Voisen (:svoisen)]

Quite smooth for me on Mac (MacBook Pro) and Windows 10 (Lenovo Yogabook) using the latest Firefox 75 nightly. Are you still seeing this?

Comment 7

[Mikel]

New URL (at the ones above are non working):
https://tecnilogica.carto.com/viz/4e058764-b9bd-49e4-9ced-e83ae8bb3cb2/public_map

If you pan quickly initially, everything is kinda smooth, but if you start zooming out/loading a lot of areas of the map and panning ,
you will clearly see the janky slowdown animations (the animation of which the map is starting to stop).

Tested on the latest 76.0a1 Nightly BuildId 20200326093308

Can you see the jank now?

Comment 8

[Sean Voisen (:svoisen)]

Sorry, I'm still unable to reproduce. Would you be able to make a recording of the jankiness and share it here?

Hiro: Do you have a Windows 10 machine on which you can test this whenever you have a chance?

Comment 9

[Hiroyuki Ikezoe (:hiro)]

I can sometime see a transform animation which doesn't run on the compositor because the transformed frame is too large. That's bug 1100357.

Comment 10

[Hiroyuki Ikezoe (:hiro)]

The site seems not available any more...

Comment 11

[Mikel]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #10)

The site seems not available any more...

Updated URL.

Comment 12

[Hiroyuki Ikezoe (:hiro)]

Now the transform animation in question runs on the compositor on Nightly. Mikel, do you still see the jank? If so, taking a profile would be a next step.

Comment 13

[Mikel]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #12)

Now the transform animation in question runs on the compositor on Nightly. Mikel, do you still see the jank? If so, taking a profile would be a next step.

Yes, looks much better, but from a performance recording while panning it looks like there are a lot of expensive DOM events and recalculations of styles, are there any plans on making optimizations in that area?

Comment 14

[Hiroyuki Ikezoe (:hiro)]

It depends on what's actually happening. It's hard to tell without seeing it, a profile will show us I guess.

Comment 15

[Wayne Mery (:wsmwk)]

(In reply to Hiroyuki Ikezoe (:hiro) from comment #14)

It depends on what's actually happening. It's hard to tell without seeing it, a profile will show us I guess.

https://profiler.firefox.com/

Comment 16

[Mikel]

Hey Wayne,

1. I've updated the URL to be valid again as the one before is invalid for some reason..
2. These are recordings of me panning the map
   a. recorded with the "Graphics" profile:
   https://share.firefox.dev/3QnZrxE
   B. Recorded with the "Nightly" profile:
   https://share.firefox.dev/3AjX0XT

Anything

Comment 17

[Mikel]

Sorry, please ignore my last comment, it got cut out and point #1 is not valid -. No URL change is needed + the recordings are valid.

Thanks!

Comment 18

[Hiroyuki Ikezoe (:hiro)]

Unfortunately, the feature improved the site has been disabled again since bug 1760918. I am afraid we don't yet have any plan to enable it again.