1760918 - Disable partial-prerender animation on all channels

Status: RESOLVED FIXED

(Core :: CSS Transitions and Animations, task)

Description

[Hiroyuki Ikezoe (:hiro)]

Given that there are plenty bug reports about partial pre-render animations, and I don't have time to investigate all cases now, I'd like to disable the feature on all channels.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1760918 - Disable partial pre-render animations on all channels. r?boris

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19b7a733941f
Disable partial pre-render animations on all channels. r=boris

Comment 3

[Sandor Molnar[:smolnar]]

Backed out changeset 19b7a733941f (bug 1760918) for causing mochitest failures in test_transitions_per_property.

Backout link: https://hg.mozilla.org/integration/autoland/rev/10178bda5cdd23c669578c163c350adf728a08a8

Push with failures

Failure log

INFO - TEST-PASS | layout/style/test/test_transitions_per_property.html | compositor transform transition from 'rotate(-180deg)' to 'none' at 2/3rds duration matches computed style: OMTA style and computed style should be equal - OMTA matrix(0.5, -0.866025, 0.866025, 0.5, 0, 0), computed matrix(0.5, -0.866025, 0.866025, 0.5, 0, 0) 
[task 2022-03-23T02:39:52.079Z] 02:39:52     INFO - Buffered messages finished
[task 2022-03-23T02:39:52.082Z] 02:39:52     INFO - TEST-UNEXPECTED-FAIL | layout/style/test/test_transitions_per_property.html | compositor transform transition from 'matrix(2, 0, 0, 2, 10, 20) scale(2)' to 'none' at 2/3rds duration matches computed style: should be animating on compositor 
[task 2022-03-23T02:39:52.082Z] 02:39:52     INFO -     SimpleTest.ok@SimpleTest/SimpleTest.js:417:16
[task 2022-03-23T02:39:52.082Z] 02:39:52     INFO -     window.omta_is_approx@layout/style/test/animation_utils.js:588:13
[task 2022-03-23T02:39:52.082Z] 02:39:52     INFO -     runTransformTest@layout/style/test/test_transitions_per_property.html?currentTestURL=layout%2Fstyle%2Ftest%2Ftest_transitions_per_property.html&closeWhenDone=1&showTestReport=false&expected=pass:3162:17
[task 2022-03-23T02:39:52.099Z] 02:39:52     INFO - TEST-PASS |

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Hmm looks like there's a test case where a transform animation on a large element. Did I add it?

Comment 5

[Hiroyuki Ikezoe (:hiro)]

The test case in question is; 'matrix(2, 0, 0, 2, 10, 20) scale(2)', it wasn't me.

But I did use width:200px for the target element to make the test works with xorig runs in bug 1716410. So it was me. :)

I will tweak the value not to be going to be overflowed by the matrix inside (500x300) size iframe.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ab8d1869fbf
Disable partial pre-render animations on all channels. r=boris

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/0ab8d1869fbf

Comment 8

[Alexandru Ionescu (needinfo me) [:alexandrui]]

== Change summary for alert #33627 (as of Thu, 24 Mar 2022 16:01:45 GMT) ==

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
2%	ebay PerceptualSpeedIndex	linux1804-64-shippable-qr	cold fission webrender	1,167.00 -> 1,192.17

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=33627

Comment 9

[Alexandru Ionescu (needinfo me) [:alexandrui]]

(In reply to Sandor Molnar from comment #3)

Backed out changeset 19b7a733941f (bug 1760918) for causing mochitest failures in test_transitions_per_property.

Backout link: https://hg.mozilla.org/integration/autoland/rev/10178bda5cdd23c669578c163c350adf728a08a8

Push with failures

Failure log

INFO - TEST-PASS | layout/style/test/test_transitions_per_property.html | compositor transform transition from 'rotate(-180deg)' to 'none' at 2/3rds duration matches computed style: OMTA style and computed style should be equal - OMTA matrix(0.5, -0.866025, 0.866025, 0.5, 0, 0), computed matrix(0.5, -0.866025, 0.866025, 0.5, 0, 0) 
[task 2022-03-23T02:39:52.079Z] 02:39:52     INFO - Buffered messages finished
[task 2022-03-23T02:39:52.082Z] 02:39:52     INFO - TEST-UNEXPECTED-FAIL | layout/style/test/test_transitions_per_property.html | compositor transform transition from 'matrix(2, 0, 0, 2, 10, 20) scale(2)' to 'none' at 2/3rds duration matches computed style: should be animating on compositor 
[task 2022-03-23T02:39:52.082Z] 02:39:52     INFO -     SimpleTest.ok@SimpleTest/SimpleTest.js:417:16
[task 2022-03-23T02:39:52.082Z] 02:39:52     INFO -     window.omta_is_approx@layout/style/test/animation_utils.js:588:13
[task 2022-03-23T02:39:52.082Z] 02:39:52     INFO -     runTransformTest@layout/style/test/test_transitions_per_property.html?currentTestURL=layout%2Fstyle%2Ftest%2Ftest_transitions_per_property.html&closeWhenDone=1&showTestReport=false&expected=pass:3162:17
[task 2022-03-23T02:39:52.099Z] 02:39:52     INFO - TEST-PASS |

== Change summary for alert #33641 (as of Fri, 25 Mar 2022 17:11:16 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
3%	ebay PerceptualSpeedIndex	linux1804-64-shippable-qr	fission warm webrender	942.33 -> 916.80

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=33641