Last Comment Bug 1197699 - always store the ip address in the logincookies table
: always store the ip address in the logincookies table
Status: RESOLVED FIXED
:
Product: bugzilla.mozilla.org
Classification: Other
Component: General (show other bugs)
: Production
: Unspecified Unspecified
-- normal (vote)
: ---
Assigned To: Byron Jones ‹:glob›
:
:
Mentors:
Depends on:
Blocks: 1192687
  Show dependency treegraph
 
Reported: 2015-08-24 01:05 PDT by Byron Jones ‹:glob›
Modified: 2015-08-25 20:39 PDT (History)
5 users (show)
See Also:
Due Date:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
1197699_1.patch (3.77 KB, patch)
2015-08-24 01:24 PDT, Byron Jones ‹:glob›
dylan: review+
Details | Diff | Splinter Review

Description User image Byron Jones ‹:glob› 2015-08-24 01:05:05 PDT
we should always store the ip address in the logincookies table, and have a separate column restrict_ip_address or something similar to know if the login cookie must be restricted to this IP address or not.
Comment 1 User image Byron Jones ‹:glob› 2015-08-24 01:24:42 PDT
Created attachment 8651657 [details] [diff] [review]
1197699_1.patch
Comment 2 User image Dylan Hardison [:dylan] 2015-08-24 05:48:44 PDT
Comment on attachment 8651657 [details] [diff] [review]
1197699_1.patch

Review of attachment 8651657 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan
Comment 3 User image Byron Jones ‹:glob› 2015-08-24 08:30:19 PDT
schema only:

To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   57f911c..24e4c03  master -> master
Comment 4 User image Byron Jones ‹:glob› 2015-08-24 22:37:34 PDT
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   85adb94..90a6182  master -> master
Comment 5 User image Frédéric Buclin 2015-08-25 10:34:57 PDT
It's a pity this patch hasn't been proposed upstream as it's also requested there, see bug 1060970. Unless your patch is a hack, which doesn't seem to be the case, could you attach it there too, please? No need to do the work twice if the patch already exists.

Note You need to log in before you can comment on or make changes to this bug.