The default bug view has changed. See this FAQ.

always store the ip address in the logincookies table

RESOLVED FIXED

Status

()

bugzilla.mozilla.org
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: glob, Assigned: glob)

Tracking

Production

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
we should always store the ip address in the logincookies table, and have a separate column restrict_ip_address or something similar to know if the login cookie must be restricted to this IP address or not.
(Assignee)

Comment 1

2 years ago
Created attachment 8651657 [details] [diff] [review]
1197699_1.patch
Attachment #8651657 - Flags: review?(dylan)
Comment on attachment 8651657 [details] [diff] [review]
1197699_1.patch

Review of attachment 8651657 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan
Attachment #8651657 - Flags: review?(dylan) → review+
(Assignee)

Comment 3

2 years ago
schema only:

To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   57f911c..24e4c03  master -> master
(Assignee)

Comment 4

2 years ago
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   85adb94..90a6182  master -> master
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED

Comment 5

2 years ago
It's a pity this patch hasn't been proposed upstream as it's also requested there, see bug 1060970. Unless your patch is a hack, which doesn't seem to be the case, could you attach it there too, please? No need to do the work twice if the patch already exists.
(Assignee)

Updated

2 years ago
See Also: → bug 1060970
You need to log in before you can comment on or make changes to this bug.