1197944 - The bug 647010 (HTTP authentication from sub-resources) cause some problems. Change the pref to revert the behavior

Status: VERIFIED FIXED

(Core :: Networking: HTTP, defect)

Description

[Dragana Damjanovic [:dragana]]

The bug 647010 cause some problems. Change the pref to revert the behavior.

See also bug 1189268.

Comment 1

[Dragana Damjanovic [:dragana]]

Attachment: bug_1197944.patch

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

[Tracking Requested - why for this release]: The patch as landed for Firefox 40.0 via bug 647010 caused lots of troubles for users. See comments on that other bug and maybe other sources like SUMO. I wonder if we should include turning of the pref in one of the next security releases for 40.0.3 if we will have one.

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Make sense. Tracking (even for 40 as we might cancel the current build)

Comment 4

[Dragana Damjanovic [:dragana]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=483317af7d1c

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/21ffbd85373a

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/21ffbd85373a

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Dragana, Jason, do you think we should hot fix this for the 40 users? Thanks

Comment 8

[Jason Duell]

If it's easy enough, let's hotfix (this is just a pref change, and we've used both codepaths in releases before, so there's really no risk).  OTOH this is only breaking small corners of the Internet, so if a hotfix is a lot of work we could live with waiting another release.

Comment 9

[Dragana Damjanovic [:dragana]]

Comment on attachment 8651912 [details] [diff] [review]
bug_1197944.patch

Approval Request Comment
[Feature/regressing bug #]: Bug 647010
[User impact if declined]: Http authentication dialog for cross-origin subresources is blocked. See bug 1200247, 1189268 and some comments in bug 647010
[Describe test coverage new/current, TreeHerder]: This is only pref change. The code path that the pref change will use, was tested by a test in the patch from bug 647010 and also by some users(bug 1200247 and 1189268)
[Risks and why]: Low risk
[String/UUID change made/needed]: none

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Dragana, there is a chance that we might hotfix this. Could you please also request uplift to mozilla-release?

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Dragana, Jason, do you know whether this also affects esr38?

Comment 12

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8651912 [details] [diff] [review]
bug_1197944.patch

Given that this issue is affecting a significant number of our end-users, let's uplift soon to Aurora42 and Beta41.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I can verify that it works again in Nightly builds at least for the instance I have seen it with internally.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ca0ab2a3305b

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ed215f5df75e

Comment 16

[Jason Duell]

Comment on attachment 8651912 [details] [diff] [review]
bug_1197944.patch

Review of attachment 8651912 [details] [diff] [review]:
-----------------------------------------------------------------

per comment 10

Comment 17

[Jason Duell]

re: comment 11: Given that bug 647010 landed on FF 40 I assume this does not affect esr 38.  Dragana can hopefully confirm.

Comment 18

[Dragana Damjanovic [:dragana]]

This change is not in esr 38. It landed only on FF 40.

Comment 19

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

esr38 status -> unaffected based on comment 18.

Comment 22

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8651912 [details] [diff] [review]
bug_1197944.patch

Removing this flag as this fix landed in 41, 42 and 43.