Closed Bug 1198019 Opened 4 years ago Closed 4 years ago

GC allocation trigger button should snap to the current GC cycle, not previous GC marker

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

41 Branch
defect
Not set

Tracking

(firefox43 fixed)

RESOLVED FIXED
Firefox 43
Tracking Status
firefox43 --- fixed

People

(Reporter: jsantell, Assigned: jsantell)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Depends on: 1197970
Comment on attachment 8653758 [details] [diff] [review]
1198019-alloc-snap.patch

Review of attachment 8653758 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

::: browser/devtools/performance/views/details-waterfall.js
@@ +149,1 @@
>      for (let marker of markers) {

Can you file a follow up to investigate creating a side-array of only the gc markers the first time we iterate over markers (when rendering the waterfall, since we had to have done that once in order to click the button and run this code) so that we can use that side-array here and only iterate over the relatively few markers we care about? I imagine it shouldn't be too hard (famous last words) and should save us a bunch of work here. Does that make sense?
Attachment #8653758 - Flags: review?(nfitzgerald) → review+
Created bug 1199500 for caching GC markers
https://hg.mozilla.org/mozilla-central/rev/a812ab9b77bb
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.