1198302 - Browser hangs when plugin returns error from NPP_NEW when Asynchronous Plugin Initialization is enabled

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Milan Burda (Skype/Microsoft)]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:40.0) Gecko/20100101 Firefox/40.0
Build ID: 20150812163655

Steps to reproduce:

Return NPERR_INVALID_URL from NPP_New when dom.ipc.plugins.asyncInit is enabled.

Context:

Check if the hosting website is allowed to instantiate our plugin. (For example by getting NPNVdocumentOrigin and comparing to a list of allowed origins)
If the plugin is not allowed to run, we return NPERR_INVALID_URL from NPP_New.


Actual results:

The browser hangs.


Expected results:

The plugin initialization should have failed without hanging the whole browser.

Comment 1

[Milan Burda (Skype/Microsoft)]

It is happening on both Windows 10 and OS X 10.9.5

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Do you have call stacks for this type of hang?

Comment 3

[Milan Burda (Skype/Microsoft)]

Attachment: npp_new_hang.txt

Adding crash dump

Comment 4

[Milan Burda (Skype/Microsoft)]

Attachment: Simple NPAPI plugin + test page, which repros the issue

You can reproduce this issue with the attached NPAPI_HelloWorld_Mac.zip

Steps:
1. Uncomment "return NPERR_INVALID_URL" at the top of NPP_New (PluginAPI.mm)
2. Build (installNPAPIPlugin.sh script creates a symlink to ~/Library/Internet Plug-Ins)
3. Open website/index.html
4. Observer the browser hanging

Comment 5

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Patch

A pretty straightforward patch. We weren't telling WaitForInit that an init failure had occurred. I'm working on a regression test for bug 1115436 that will catch this in the future.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1a6139dad4b1

Comment 7

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8653760 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: async plugin init
[User impact if declined]: browser could hang if JS in page is waiting for plugin to initialize but plugin fails during init
[Describe test coverage new/current, TreeHerder]: Plugin test suite, manually. Regression test for this specific issue is being added in bug 1115436.
[Risks and why]: Low, trivial patch that flips a boolean.
[String/UUID change made/needed]: None

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1a6139dad4b1

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8653760 [details] [diff] [review]
Patch

Taking it into aurora to increase the coverage, Ritu will make the call for beta.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/179a6b892609

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8653760 [details] [diff] [review]
Patch

Browser hangs are bad, let's uplift the fix to Beta41. The fix seems quite safe.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/cc07ed95653e