1198405 - chrome.tabs.query’s url parameter doesn't match “one or more URL patterns”.

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect, P1)

Description

[Blake Winton (:bwinton) (:☕️)]

The documents say it should match one or more url patterns[0].
Our code does a simple != match on the string value[1].

It would be awesome if we handled not only a single pattern, but also arrays of patterns and strings, intermingled!  :)

[0] https://developer.chrome.com/extensions/tabs#property-queryInfo-url
[1] https://dxr.mozilla.org/mozilla-central/source/browser/components/extensions/ext-tabs.js#366

Comment 1

[Blake Winton (:bwinton) (:☕️)]

https://dxr.mozilla.org/mozilla-central/source/toolkit/components/extensions/ExtensionContent.jsm?offset=100#95 looks like it might be helpful in implementing this…

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

I'm guessing Blake's link was meant to refer to something about MatchPattern, which is how we would implement this:
https://dxr.mozilla.org/mozilla-central/source/toolkit/modules/addons/MatchPattern.jsm

Comment 3

[Johann Hofmann [:johannh]]

Attachment: Match one or more URL patterns in tabs.query

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8675592 [details] [diff] [review]
Match one or more URL patterns in tabs.query

Review of attachment 8675592 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great! Thanks.

::: browser/components/extensions/ext-tabs.js
@@ +428,5 @@
>                return false;
>              }
>            }
>  
> +          if (pattern && !pattern.matches(ioService.newURI(tab.url, null, null))) {

It's a bit easier to do Services.io.newURI. You'll want to import Services.jsm at the top using Cu.import.

Comment 5

[Johann Hofmann [:johannh]]

Attachment: Match one or more URL patterns in tabs.query

Comment 6

[Johann Hofmann [:johannh]]

Comment on attachment 8676715 [details] [diff] [review]
Match one or more URL patterns in tabs.query

Done :)

Comment 7

[Johann Hofmann [:johannh]]

Attachment: Use MatchPattern to match URLs in tabs.query

Comment 8

[Johann Hofmann [:johannh]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dce1dcb8f88c

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/2676b3f48d03

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2676b3f48d03