fix id_pk_serverAuth typo in pkixcert.cpp

RESOLVED FIXED in Firefox 59

Status

()

P1
normal
RESOLVED FIXED
4 years ago
9 months ago

People

(Reporter: keeler, Assigned: manikishanghantasala)

Tracking

Trunk
mozilla59
Points:
---

Firefox Tracking Flags

(firefox59 fixed)

Details

(Whiteboard: [psm-assigned])

Attachments

(1 attachment, 1 obsolete attachment)

Whiteboard: [psm-cleanup]
Priority: -- → P5
(Assignee)

Comment 1

a year ago
I would like to take this over . I am a newbie?
(Assignee)

Comment 2

a year ago
(In reply to manikishanghantasala from comment #1)
> I would like to take this over . I am a newbie.
(Assignee)

Comment 3

a year ago
Posted file bug-1198481 (obsolete) —
[Security approval request comment]
How easily could an exploit be constructed based on the patch?

Do comments in the patch, the check-in comment, or tests included in the patch paint a bulls-eye on the security problem?

Which older supported branches are affected by this flaw?

If not all supported branches, which bug introduced the flaw?

Do you have backports for the affected branches? If not, how different, hard to create, and risky will they be?

How likely is this patch to cause regressions; how much testing does it need?
Attachment #8933903 - Flags: sec-approval?
Attachment #8933903 - Flags: review+
Comment on attachment 8933903 [details]
bug-1198481

Settings sec-approval? on an unrated, public, non-security bug without answering any of the template questions isn't very useful.
Attachment #8933903 - Flags: sec-approval?
(Assignee)

Comment 5

a year ago
sorry I am new to this can you please help me explaining what should be done?
(In reply to manikishanghantasala from comment #5)
> sorry I am new to this can you please help me explaining what should be done?

Please don't change any further bug flags :)

The patch you uploaded is empty. When you have a new version ready, please upload it as type "patch" and ask for review? from :keeler. Then we can assign this one to you.
(Assignee)

Comment 7

a year ago
Attachment #8934115 - Flags: review?(dkeeler)
Attachment #8933903 - Attachment is obsolete: true
Assignee: nobody → manikishanghantasala
Status: NEW → ASSIGNED
Comment on attachment 8934115 [details] [diff] [review]
Bug-1198481.patch

Review of attachment 8934115 [details] [diff] [review]:
-----------------------------------------------------------------

Great - thanks!
Normally the next step would be to run this through try, but since this is a comment-only change, we can mark it `checkin-needed` directly.
Attachment #8934115 - Flags: review?(dkeeler) → review+
Keywords: checkin-needed
Priority: P5 → P1
Whiteboard: [psm-cleanup] → [psm-assigned]

Comment 9

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8577d0b83990
Fixed typo 'id_pk_serverAuth' to 'id_kp_serverAuth'. r=keeler
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8577d0b83990
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
status-firefox43: affected → ---
You need to log in before you can comment on or make changes to this bug.