119874 - Drag a new url onto personal toolbar, show no title.

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Bolian Yin]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.7) Gecko/20011226
BuildID:    2001122617

Drag a url on from Webpage onto the personal Toolbar, if the url is not in your
bookmark and is not visited before, only a bookmark icon show on the personal
toolbar without title. 

Reproducible: Always
Steps to Reproduce:
1. open a webpage which is new to your browser
2. drag a url from the page onto your perosnal toolbar


Actual Results:  a bookmark icon appears on the personal toolbar

Expected Results:  a icon and title should be there

Comment 1

[Bolian Yin]

personalToolbarObserver.getSupportedFlavours in navigatorDD.js does not contain
support for "text/x-moz-url", if I add the line:

flavourSet.appendFlavour("text/x-moz-url");

before "text/unicode", the problem disappear.  I do not know why it is not added
before, is this the good way to correct this problem? Who can tell me? 
BTW, the same problme exists on Solaris/SPARC, but not on windows 2000/i386

Comment 2

[Chris Lyon]

Bolian, are you dragging selected text or a link?  If it's text, then this is 
a duplicate of bug 87095.

Comment 3

[Bolian Yin]

Sorry for the ambiguousness, what I mean is dragging a link. 

Comment 4

[Bolian Yin]

Attachment: add support for "text/x-moz-url" before "text/unicode"

I have tested on Linux and Solaris.  Please review

Comment 5

[John Levon]

reopen bug 84976 ?

Comment 6

[Keyser Sose]

Marking NEW. Bolian you should contact the correct owner on this list
http://www.mozilla.org/owners.html and get a review/sr for the patch to be
checked in. Thanks for the patch.

Comment 7

[Ben Goodger (use ben at mozilla dot org for email)]

Has this since been fixed? It works for me....

Comment 8

[Pierre Chanial]

Currently, personalToolbarDNDObserver.onDrop does not consider flavour and does
not pick up the best one.
Imho, the best approach would imply to merge the way how dragged data is
retrieved in bookmarks.xml (correct implementation, but no history look up) and
the one in personalToolbarDNDObserver.

Comment 9

[Pierre Chanial]

*** Bug 148289 has been marked as a duplicate of this bug. ***

Comment 10

[Jesse Ruderman]

I think this bug happens on all non-Windows platforms.

Comment 11

[Ben Goodger (use ben at mozilla dot org for email)]

-> Jan for buffy

Comment 12

[Thomas Brown]

Problem still occurs on Mozilla 1.2a 2002091014 on Win2K.

Comment 13

[Jay Shampur]

I found that when I launch mozilla 1.3b as root, I can drag URL's to the toolbar
and they are shown there.  As a normal user, it does not allow me to drag the
URL's to the personal toolbar.

When I installed Mozilla, I installed as root from the RPM's (RH8), executed
mozilla once as root and then executed as the normal user.

...Jay

Comment 14

[Jan Varga [:janv]]

Pierre, this is fixed, isn't it ?

Comment 15

[Pierre Chanial]

yes I fixed it in Phoenix

Comment 16

[Pierre Chanial]

marking fixed