Closed
Bug 1199035
Opened 9 years ago
Closed 9 years ago
Theme review page shows current user as "Reviewer"
Categories
(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect)
addons.mozilla.org Graveyard
Admin/Editor Tools
Tracking
(Not tracked)
VERIFIED
FIXED
2015-09-10
People
(Reporter: jorgev, Assigned: mozilla)
References
()
Details
(Whiteboard: [goodfirstbug])
If you're a theme reviewer or an admin, you can access theme review pages: https://addons.mozilla.org/editors/themes/queue/single/indie-blue-floral This page shows some metadata like Artist, Categories, etc. The last one is "Reviewer". However, the only thing it displays is the email address of the current logged in user. Since a detailed Review History is already part of this page, the Reviewer string is not only wrong but also unnecessary. We should just drop it.
I've hopefully fixed this, https://github.com/mozilla/olympia/pull/711
Updated•9 years ago
|
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
Comment 2•9 years ago
|
||
Commits pushed to master at https://github.com/mozilla/olympia https://github.com/mozilla/olympia/commit/ccfe1819523458500a6bad538a5ac44507b026ce Remove 'Reviewer' from theme review page (bug 1199035) https://github.com/mozilla/olympia/commit/c07ca35ac51c9328c06aaa97a255258969b765e2 Merge pull request #711 from Azelphur/master Remove 'Reviewer' from theme review page (bug 1199035)
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2015-09-10
Comment 3•9 years ago
|
||
Congrats on fixing your first bug! I've added you here: https://wiki.mozilla.org/Marketplace/Contributing/Sep2015#Contributor_Recognition. Feel free to edit the entry with your name, etc :-)
Comment 4•9 years ago
|
||
Verified as fixed on AMO-dev FF40(Win 7). Postfix screenshot: http://screencast.com/t/oDTLs86hNaW Closing bug.
Status: RESOLVED → VERIFIED
Updated•8 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•