The default_popups for browserActions in the menu panel appear in the wrong place.

RESOLVED DUPLICATE of bug 1217129

Status

()

Toolkit
WebExtensions: Untriaged
RESOLVED DUPLICATE of bug 1217129
2 years ago
2 years ago

People

(Reporter: bwinton, Unassigned)

Tracking

Trunk
Points:
---
Bug Flags:
blocking-webextensions +

Firefox Tracking Flags

(firefox43 affected)

Details

(Whiteboard: [webextension-polish][browserAction])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

2 years ago
As shown in https://dl.dropboxusercontent.com/u/2301433/Firefox/WebExtensions/MenuPopup.png

Uh, we actually need a better spec for this, I think, since we don't really pop stuff up from there.  The interaction there is more sliding the current menu over, and exposing the content on the right, as in https://dl.dropboxusercontent.com/u/2301433/Firefox/WebExtensions/MenuPanel.png

Updated

2 years ago
Whiteboard: [webextension-polish] → [webextension-polish][browserAction]

Updated

2 years ago
Assignee: nobody → mjaritz
Blocks: 1214433
Can someone please attach a testcase add-on with a matching screenshot?
(Reporter)

Comment 2

2 years ago
Created attachment 8674435 [details]
browseractionmenupanel.xpi

Screenshot at https://www.dropbox.com/s/xjnk1pnkbj3kiwl/Screenshot%202015-10-15%2015.39.57.png?dl=0
Wow. That's super broken. I can't reproduce the positioning problem, but the size calculation is definitely wrong. I think they're two separate bugs. I suspect we may have to recalculate the size periodically, and make sure we reposition correctly when we do.
(Reporter)

Comment 4

2 years ago
Oh, yeah, the size is totally wrong, and I think mostly my fault for not specifying a size on the original page…  The positioning problem is that the menupanel goes away, so the popup is left floating in space.  It should probably anchor off the menu button in that case, or the menu panel shouldn't disappear.
Can we default to sliding the menu over and exposing the content to the right as history currently does, and as Blake mentioned in the first comment? Or would this break the layout of add-on panels? If so, we should provide add-on developers with an option to specify a different layout of their panel for the case of it being in the menu.
As a fallback we should hang the panel off the menu button as Blake suggested. Having the panel appear above the menu panel will lead to too much stacking.

Updated

2 years ago
Assignee: mjaritz → nobody

Updated

2 years ago
Flags: blocking-webextensions+
(Reporter)

Comment 6

2 years ago
Should the menu button remain pressed or not?  I'll code it up one way, and we'll see what it looks like…
(Reporter)

Updated

2 years ago
Assignee: nobody → bwinton
(Reporter)

Comment 7

2 years ago
Created attachment 8679553 [details]
MozReview Request: Bug 1199052 - Hang browserAction panels off of the menu button if they're in the menu. ui-r=maritz, r=billm

Bug 1199052 - Hang browserAction panels off of the menu button if they're in the menu. ui-r=maritz, r=billm
Attachment #8679553 - Flags: review?(wmccloskey)
Attachment #8679553 - Flags: review?(mjaritz)
(Reporter)

Updated

2 years ago
Attachment #8679553 - Flags: review?(mjaritz) → ui-review?(mjaritz)
Comment on attachment 8679553 [details]
MozReview Request: Bug 1199052 - Hang browserAction panels off of the menu button if they're in the menu. ui-r=maritz, r=billm

I see 2 ways for this to work:

1) Keep the menu-button pressed when the WebExtension panel is hanging off it. Close the panel on clicking the menu-button. This way the button would work as every other button, closing the panel hanging off it. (Would however for that case require 2 clicks to open the menu.)

2) Have the menu-button not pressed when the WebExtension panel is hanging off it. Close the panel, and reopen the menu on clicking the menu-button. This way the button would work as a back button if the WebExtension panel is hanging off it, and we keep quick access (1-click) to the menu.

I would suggest going with version 2 as it keeps the menu accessible.
This works in the current implementation if one clicks the menu panel near the edge of the button when the WebExtension panel is open, not however if one clicks on the icon of the menu-button.
Attachment #8679553 - Flags: ui-review?(mjaritz) → ui-review-
(Reporter)

Comment 9

2 years ago
Markus: On Windows?  Because version 2 is exactly what happens on the build I'm running on Mac OS X…
Flags: needinfo?(mjaritz)
(In reply to Blake Winton (:bwinton) (:☕️) from comment #9)
> Markus: On Windows?  Because version 2 is exactly what happens on the build
> I'm running on Mac OS X…

Yes, Windows 10.
Flags: needinfo?(mjaritz)
Should I hold off on reviewing this? The code looks fine to me.
(Reporter)

Comment 12

2 years ago
Bill: If you're happy with the code, give it an r+.  ;)  I don't _think_ I'll need to change much to get the ui-r+, but if I do, I'll re-request review…
(Reporter)

Comment 13

2 years ago
Ugh, I have no idea what's going on there.  I can reproduce it, but it makes absolutely no sense…  :P
Attachment #8679553 - Flags: review?(wmccloskey) → review+
Comment on attachment 8679553 [details]
MozReview Request: Bug 1199052 - Hang browserAction panels off of the menu button if they're in the menu. ui-r=maritz, r=billm

https://reviewboard.mozilla.org/r/23473/#review21729
(Reporter)

Comment 15

2 years ago
(This may be fixed by a variant of the patch in https://bugzilla.mozilla.org/show_bug.cgi?id=1217129#c40 :)
(Reporter)

Comment 16

2 years ago
(I'm also off this one, since I think it's related to the other bug.)
Assignee: bwinton → nobody
This is basically a dup, at this point.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1217129
You need to log in before you can comment on or make changes to this bug.