1199164 - [GTK3] Runtime warnings - gtk-menu-images and gtk-button-images deprecated

Status: RESOLVED DUPLICATE of bug 1164674

(Core :: Widget: Gtk, defect)

Description

[Petr Jašíček]

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:38.0) Gecko/20100101 Firefox/38.0
Build ID: 20150518070114

Steps to reproduce:

Run firefox under GTK3 from command line


Actual results:

Running firefox produces following warnings:

firefox:17402): GLib-GObject-WARNING **: The property GtkSettings:gtk-menu-images is deprecated and shouldn't be used anymore. It will be removed in a future version.

(firefox:17402): GLib-GObject-WARNING **: The property GtkSettings:gtk-button-images is deprecated and shouldn't be used anymore. It will be removed in a future version.



Expected results:

Running firefox should not yield deprecation warnings

Comment 1

[Petr Jašíček]

Attachment: 001_gtk3_runtime_warnings.patch

This patch fixes runtime warnings by deprecated gtk-menu-images and gtk-button-images properties. It is deprecated since GTK 3.10.

Try:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8b8e02bc5c3a

Comment 2

[Karl Tomlinson (:karlt)]

Comment on attachment 8653394 [details] [diff] [review]
001_gtk3_runtime_warnings.patch

We are expecting binary backwards compat from GTK.
Applications should not need to include these kind of workarounds and the settings cannot be removed until the gtk soname is changed.

Glib warning on this usage without G_ENABLE_DIAGNOSTIC=1 is a bug in Glib and should be fixed there.
https://bugzilla.mozilla.org/show_bug.cgi?id=1164674#c7
https://bugzilla.gnome.org/show_bug.cgi?id=732184#c22