firefox uses deprecated GtkSettings properties

ASSIGNED
Assigned to

Status

()

Core
Widget: Gtk
P5
normal
ASSIGNED
3 years ago
a year ago

People

(Reporter: Christian Stadelmann, Assigned: hub)

Tracking

(Blocks: 1 bug)

37 Branch
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: tpi:+)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

3 years ago
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Firefox/31.0
Build ID: 20150422185754

Steps to reproduce:

I started firefox to display the profile manager by running
firefox -new-instance -ProfileManager
in a terminal on Fedora 22.


Actual results:

I got this command line output:


(firefox:7444): GLib-GObject-WARNING **: The property GtkSettings:gtk-menu-images is deprecated and shouldn't be used anymore. It will be removed in a future version.

(firefox:7444): GLib-GObject-WARNING **: The property GtkSettings:gtk-button-images is deprecated and shouldn't be used anymore. It will be removed in a future version.



Expected results:

Nothing should have happened.
(Assignee)

Updated

3 years ago
Component: Untriaged → Widget: Gtk
Product: Firefox → Core
(Assignee)

Comment 1

3 years ago
The Fedora build uses Gtk3 by default. I see this on m-c too.
(Assignee)

Comment 2

3 years ago
I have a patch for this.
Assignee: nobody → hub
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
(Assignee)

Comment 3

3 years ago
Created attachment 8621929 [details] [diff] [review]
Proposed patch

I chose to set the default to FALSE. These preferences are obsolete all along Gtk3.

Patch is only for Gtk3.
Attachment #8621929 - Flags: review?(karlt)
(Assignee)

Comment 4

3 years ago
Comment on attachment 8621929 [details] [diff] [review]
Proposed patch

cancelling review for now, I have an update to come (removing code made dead by this)
Attachment #8621929 - Flags: review?(karlt)
(Assignee)

Comment 5

3 years ago
Created attachment 8622430 [details] [diff] [review]
Remove deprecated GtkSettings properties. r=
(Assignee)

Updated

3 years ago
Attachment #8621929 - Attachment is obsolete: true
(Assignee)

Comment 6

3 years ago
Comment on attachment 8622430 [details] [diff] [review]
Remove deprecated GtkSettings properties. r=

On Gtk3 image in buttons and menu item are totally deprecated.
Attachment #8622430 - Flags: review?(karlt)
Comment on attachment 8622430 [details] [diff] [review]
Remove deprecated GtkSettings properties. r=

We currently still support GTK 3 versions less than 3.10, so are not ready
to remove this code at this stage.

These warnings should only be emitted when the G_ENABLE_DIAGNOSTIC environment
variable is set.
"A warning will be generated if it is used while running with
G_ENABLE_DIAGNOSTIC=1"
https://developer.gnome.org/gobject/unstable/gobject-GParamSpec.html#G-PARAM-DEPRECATED:CAPS

It would be bad form to actually remove a property from an object in a library
attempting to provide binary backward compatibility due to the encouraged use
of g_object_get(), which would not handle removal well.
Attachment #8622430 - Flags: review?(karlt) → review-
I see the warning too :
[ludo@Oulanl ~]$ echo $G_ENABLE_DIAGNOSTIC

[ludo@Oulanl ~]$
(Assignee)

Comment 9

3 years ago
You are gonna see it until we fix it (see attached patch) or until with switch to Gtk4. Other workaround is to downgrade.
Duplicate of this bug: 1199164
Blocks: 627699

Updated

2 years ago
Priority: -- → P5
Whiteboard: tpi:+
You need to log in before you can comment on or make changes to this bug.