1199177 - KidFox: Restricted profiles - Can't install add-ons

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Profile Handling, defect)

Description

[Catalin Suciu [:csuciu]]

Latest Nightly/Aurora
Nexus 7 (5.1.1)

Steps:
1. As 'owner', enable add-ons installation
2. On the restricted profile, open Nightly/Aurora, and go to Menu -> Tools -> Add-ons
3. Select an add-on and tap on 'Add to Firefox'

Expected: Add-ons can be installed

Actual: 
- On Nightly nothing visual happens
- On Aurora, the incompatibility error message (Add-on could not be installed because is not compatible with Aurora 42.0a2) is triggered

From logs (same error for both, Nightly and Aurora):
E/GeckoConsole(13944): [JavaScript Error: "ReferenceError: _gaq is not defined" {file: "https://addons.cdn.mozilla.net/static/js/zamboni/mobile-min.js?build=1ae360d-55d5fe5f" line: 4}]

Comment 1

[Teodora Vermesan (:TeoVermesan)]

I can reproduce the issue on latest Nightly, on a regular profile, in guest mode session: nothing happens when tapping "Add to Firefox" for installing an add-on.

Comment 2

[Sebastian Kaspari (:sebastian; :pocmo)]

For the record: "Does nothing" for the "Add to Firefox" button is currently the correct behavior. We are thinking about showing something more helpful in bug 1192784.

Back to the bug: I can't really reproduce this on my N9. However if I start the browser on a restricted profile. Switch to the admin profile. Allow add-on installation. Then switch back to the restricted profile and resume(!) the browser. Then I can't install add-ons until I (re-)start the browser.

Can you confirm that stopping and starting the browser resolves the issue? (I assume you are nevertheless having a more permanent problem because you are seeing the menu items for add-ons but still can't install one.)

Comment 3

[Catalin Suciu [:csuciu]]

Restarting Firefox does not help.

Here are some more precise steps that I used to reproduce this issue on N7 (5.1.1) and Xperia Z2 (5.0.2):

1. Crate a new restricted profile
2. Go to the restricted profile's settings

if
3a. Enable Nightly and leave 'Add-ons installation' disabled
4a. Switch to the restricted profile and check that the 'Add-ons' menu item is hidden
5a. Switch back to 'owner' and enable 'Add-ons installation'
6a. Switch to the restricted profile and restart Nightly
7a. Try to install an add-on
Result: Nothing happens when trying to install an add-on

if
3b. Enable Nightly and enable 'Add-ons installation'
4b. Switch to the restricted profile and start Nightly > Add-ons CAN be installed 
5b. Switch back to 'owner' and disable 'Add-ons installation'
6b. Switch to the restricted profile and restart Nightly > 'Add-ons' menu item is hidden
7b. Switch back to 'owner' and enable 'Add-ons installation' 
8b. Switch to the restricted profile and restart Nightly
9b. Try to install an add-on
Result: Nothing happens when trying to install an add-on

Comment 4

[Sebastian Kaspari (:sebastian; :pocmo)]

Jonathan: I saw discussions on IRC in my logs that you were facing a similar problem (unrelated to restricted profiles). Did you find what was causing it? Maybe this is related.

Comment 5

[Jonathan Almeida [:jonalmeida]]

Yes, this looks similar to the problem I was seeing. I created bug 1201534 to track this. Installing addons from addons.mozilla.org should work, but direct links seem to fail.

Comment 6

[Sebastian Kaspari (:sebastian; :pocmo)]

The problem seems to be in browser.js:
https://dxr.mozilla.org/mozilla-central/rev/9ed17db42e3e46f1c712e4dffd62d54e915e0fac/mobile/android/chrome/content/browser.js#517-522

>    if (!ParentalControls.isAllowed(ParentalControls.INSTALL_EXTENSION)) {
>      // Disable extension installs
>      Services.prefs.setIntPref("extensions.enabledScopes", 1);
>      Services.prefs.setIntPref("extensions.autoDisableScopes", 1);
>      Services.prefs.setBoolPref("xpinstall.enabled", false);
>    }

If the restricted profile is entered with extension installation disabled once then this is persisted and never reset.

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

Attachment: MozReview Request: Bug 1199177 - Restricted profiles: Reset add-on preferences if restriction is not enabled. r?margaret

Bug 1199177 - Restricted profiles: Reset add-on preferences if restriction is not enabled. r?margaret

Comment 8

[:Margaret Leibovic]

Comment on attachment 8661736 [details]
MozReview Request: Bug 1199177 - Restricted profiles: Reset add-on preferences if restriction is not enabled. r?margaret

https://reviewboard.mozilla.org/r/19439/#review17419

Good catch.

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/e5b69f126a06

Comment 10

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8661736 [details]
MozReview Request: Bug 1199177 - Restricted profiles: Reset add-on preferences if restriction is not enabled. r?margaret

Approval Request Comment

[Feature/regressing bug #]: Bug 1125289 - KidFox: Restricted profiles - Hide all add-ons and apps installation/removal features and related UI

[User impact if declined]: If add-on installation has been disabled once then it can never be enabled again for the restricted profile. Feature launches in Fx42.

[Describe test coverage new/current, TreeHerder]: Local testing. No UI test support for restricted profiles yet.

[Risks and why]: Low.

[String/UUID change made/needed]: -

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e5b69f126a06

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8661736 [details]
MozReview Request: Bug 1199177 - Restricted profiles: Reset add-on preferences if restriction is not enabled. r?margaret

Important issue with a new feature, taking it.

Comment 13

[u549602]

Verified as fixed on latest Nightly.

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/9951ff11def9

Comment 15

[Flaviu Cos]

Verified as fixed in Firefox 42 Beta 1;
Device: Nexus 7 (Android 5.1.1).