Closed Bug 11992 Opened 25 years ago Closed 25 years ago

Newline and white space before doc. element is not getting reported to the DTD.

Categories

(Core :: XML, defect, P3)

Product:
Core
Component:
XML
Platform:
x86
Windows NT
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: harishd, Assigned: nisheeth_mozilla)

References

Details

(Keywords: verifyme) 

1 <?xml version="1.0"?>
2 <?xml-stylesheet type="text/css"?>
3
4<!--
5  XXXXXXXXXXX
6  YYYYYYYYYYY
7  ZZZZZZZZZZZ
8-->
9<html xmlns="http://www.w3.org/TR/REC-html40" lang="en-US">
....

In the above sample, new line in line# 3, line# 8 is not getting reported to
CWellFormedDTD::HandleToken().
Blocks: 10593
Status: NEW → ASSIGNED
Target Milestone: M12
Accepting bug and setting target milestone to M12 for now...
Target Milestone: M12 → M14
This is not a beta stopper.  Moving out to M14...
I think it would be good to fix this for beta, if possible, because of bug
10593.  Incorrect line numbers for JavaScript errors in XHTML are a rather
serious problem.  It makes things harder for developers, who are, IMO, one of
the major targets of a beta.  (I admit that the problems with JS errors on
linked scripts are even more serious - see bug 8045.)
Target Milestone: M14 → M11
David brings up a valid point.  Bringing in the bug to M11...
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
I've checked in a fix for this bug.  I added the default handler to the XML
tokenizer which looks for newlines and creates newline tokens.  Earlier, the
no default handler was registered with expat, so newlines in the document prolog
were not getting reported.
Blocks: 17907
I'm trying to verify this fix. Line #3 and #8 were not getting reported - is
this something I can visually verify? Please advise
I *think* it's possible to verify it using the XML test case for bug 10593,
which it seems you already did.
Keywords: verifyme
No longer blocks: 17907
Fixed in the July 6th build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.