1199208 - Incomplete and confusing add-on installation message

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Vasilica Tamas, QA [:vtamas]]

Reproducible on: Firefox 43.0a1, Firefox 37.0.2 across all platforms

STR
1.Launch Firefox with clean profile.
2.Navigate to https://addons.mozilla.org/en-US/firefox/addon/card-color-titles-for-trello/?src=cb-dl-created
3.Click “Add to Firefox” button to install the add-on.

ER
A comprehensive error message is displayed.

AR
A confusing error message is displayed. It is not clearly specified why this add-on could not be installed.
See screenshot: http://i.imgur.com/haaPWuN.jpg

Additional notes:
- This issue is reproducible on Firefox 43.0a1 (2015-08-26), Firefox 40.0.3, Firefox 38.2.1 and Firefox 37.0.2 under Windows 7 64-bit, Ubuntu 14.04 32-bit and Mac OS X 10.9.5
- This error also appeared for the following add-ons:
 https://addons.mozilla.org/en-US/firefox/addon/whatsapp-web-hide-media/?src=cb-dl-created
 https://addons.mozilla.org/en-US/firefox/addon/braincloud-learning-live-exten/?src=cb-dl-created

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The file requests to AMO have a different SHA256 than the file returned (tested only Card Color Tiles):

AMO url:  3b57799931ecc0e7ae5117395de116d75e5748c7b7893aa7939ef20954081577
returned: 4faf09c0e6beea4555f28be167f7a752295bea0711541e996acc602e1cb57b5e

In the Edit Listing view for the addon, I only see on upload (no idea if that view shows all for a single version).

Uploads for these three addons are from the 25th and 26th of this month.

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

For all 3 cases I noted this:

1) I could reproduce the bug.
2) The review history shows two reviews done in quick succession of each other (not sure if they were caused by a server error or reviewer double submission).
3) Triggering the hash recalculation in the admin page seems to have fixed the problem for the three of them, at least for now.

Comment 3

[Mathieu Agopian [:magopian]]

After some more investigation, it seems this issue is only affecting some add-ons that were reviewed on the 26th of august (we had some server side glitches on production).

Forcing a save (and thus a hash recalculation) in the admin pages does indeed fix the issue, so let's see if there's any other add-ons impacted by this issue.

If we see that it's impacting a lot of other add-ons, we'll run a script server-side to update all the add-ons that have a mismatched hash (might take some time to run).

Comment 4

[Mathieu Agopian [:magopian]]

Marking this bug as resolved, we'll reopen if needed, thanks for reporting it!

Comment 5

[Vasilica Tamas, QA [:vtamas]]

Encountered other 2 add-ons that returns the same error (http://i.imgur.com/4LZRJYw.png):
https://addons.mozilla.org/en-US/firefox/addon/jsinjectiontest/?src=cb-dl-created
https://addons.mozilla.org/en-US/firefox/addon/comuniti-screen-sharing/?src=cb-dl-created

The following log is thrown in browser console:
1449153630579	addons.xpi	WARN	Download of https://addons.mozilla.org/firefox/downloads/file/371229/comuniti_screen_sharing-1.0-fx.xpi?src=cb-dl-created failed: Downloaded file hash (0f0fc30c98e4beab1438f09d299caeb73fcc9b25ac58e95fbc1037a0d3521d49) did not match provided hash (3e1f8751428da046086e28e9d74116f1470e7b04f0200d05226190b7339c132c)

(Reproduced on Firefox 43 beta 8, Firefox 44.0a2 and Firefox 45.0a1 using Windows 7 64-bit, Ubuntu 14.04 32-bit and Mac Os X 10.11.1)


Mathieu, how we should proceed in this situation? Should I reopen this bug or file a new one?

Comment 6

[Mathieu Agopian [:magopian]]

I wonder if the files for those add-ons have been submitted on the same day as the other faulty ones? If so, I guess asking Jorge to fix them is the way to go.

Comment 7

[Jorge Villalobos [:jorgev] (he/him)]

They are more recent. I reset their hashes, so I think the error should go away soon. I see some reports on GitHub of similar problems, though.