Top site tiles are shown with too-trimmed domains

RESOLVED FIXED

Status

()

Firefox for iOS
Home screen
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: rnewman, Assigned: rnewman)

Tracking

unspecified
All
iOS
Dependency tree / graph

Firefox Tracking Flags

(fxios-v1.0 wontfix, fxios-v1.1 fixed, fxios-v1.0.5 fixed, fxios1.0.5+)

Details

Attachments

(1 attachment)

48 bytes, text/x-github-pull-request
fluffyemily
: review+
tecgirl
: ui-review+
Details | Review | Splinter Review
(Assignee)

Description

3 years ago
Bug 1196088 was too aggressive. For example, irccloud.mozilla.org shows as mozilla.org. This is the same as our highlight in the URL bar.

We should fix this to only remove noise subdomains (www, m, r).
tracking-fxios: ? → 1.0.5+
The highlighting is the same as desktop which I believe is meant to only show the 'significant' and actual domain of the website to prevent malicious urls from pre-pending a bunch of garbage. Some more info: https://wiki.mozilla.org/Public_Suffix_List
(Assignee)

Updated

3 years ago
Depends on: 1200687
(Assignee)

Comment 2

3 years ago
Created attachment 8656328 [details] [review]
Pull req.
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Attachment #8656328 - Flags: ui-review?(randersen)
Attachment #8656328 - Flags: review?(etoop)
Comment on attachment 8656328 [details] [review]
Pull req.

LGTM. Hosts look far more sensible.
Attachment #8656328 - Flags: review?(etoop) → review+
Attachment #8656328 - Flags: ui-review?(randersen) → ui-review+
(Assignee)

Comment 4

3 years ago
master: 5a3a6b7
v1.0: ccead83
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-fxios-v1.0: --- → wontfix
status-fxios-v1.0.5: --- → fixed
status-fxios-v1.1: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.