Closed Bug 1199434 Opened 4 years ago Closed 4 years ago

[e10s] Print preview doesn't show alert if printer was't found.

Categories

(Core :: Print Preview, defect)

x86
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
e10s m8+ ---
firefox43 --- fixed

People

(Reporter: arni2033, Assigned: mconley)

References

Details

Attachments

(3 files)

STR:   (Win7_64bit, Nightly 43.0a1 32bit   ID 20150827030213, new profile)
1. Open page http://example.org/ in remote browser
2. Open menu bar (Alt or F10), click File->Print Preview

Result:       No alerts, operation just aborts.
Expectations: Alert should be displayed, just like in non-e10s mode.

Video - Non-e10s: https://dl.dropboxusercontent.com/s/97pp74dtt5wwyod/Print%20preview%20-%20no%20printer%20-%20normal.webm?dl=0

Video - e10s:     https://dl.dropboxusercontent.com/s/vdn1igkcuc9ezl1/Print%20preview%20-%20no%20printer%20-%20e10s.webm?dl=0
tracking-e10s: --- → ?
Assignee: nobody → bobowen.code
OS: Unspecified → Windows 7
Hardware: Unspecified → x86
Um, I have Win7 x86_64 (not x86) if that matters... But I still think it's more general issue.
Yoink
Assignee: bobowen.code → mconley
Bug 1199434 - [e10s] Print preview doesn't show alert if printer was't found. r?Mossop, r?smaug
Comment on attachment 8661476 [details]
MozReview Request: Bug 1199434 - Fire an event when the print engine encounters an error. r=smaug

Bug 1199434 - Fire an event when the print engine encounters an error. r?smaug

The print engine used to directly cause a prompt to be displayed in the most
recent window in the event of an error. This patch causes the print engine to
fire an event instead so that the front-end can choose to display or ignore
the error.
Attachment #8661476 - Attachment description: MozReview Request: Bug 1199434 - [e10s] Print preview doesn't show alert if printer was't found. r?Mossop, r?smaug → MozReview Request: Bug 1199434 - Fire an event when the print engine encounters an error. r?smaug
Comment on attachment 8661476 [details]
MozReview Request: Bug 1199434 - Fire an event when the print engine encounters an error. r=smaug

Bug 1199434 - Fire an event when the print engine encounters an error. r?smaug

The print engine used to directly cause a prompt to be displayed in the most
recent window in the event of an error. This patch causes the print engine to
fire an event instead so that the front-end can choose to display or ignore
the error.
Comment on attachment 8661479 [details]
MozReview Request: Bug 1199434 - Send printer error messages to the parent process to report to the user. r=Mossop

Bug 1199434 - Send printer error messages to the parent process to report to the user. r?Mossop

The printing back-end used to be in charge of opening up an error dialog
when things go wrong with printing. Now we fire an event and let PrintUtils
do the work of showing the error message. This has the added bonus of making
the error messages work with e10s.
Comment on attachment 8661476 [details]
MozReview Request: Bug 1199434 - Fire an event when the print engine encounters an error. r=smaug

Bug 1199434 - Fire an event when the print engine encounters an error. r?smaug

The print engine used to directly cause a prompt to be displayed in the most
recent window in the event of an error. This patch causes the print engine to
fire an event instead so that the front-end can choose to display or ignore
the error.
Attachment #8661476 - Flags: review?(bugs)
Comment on attachment 8661479 [details]
MozReview Request: Bug 1199434 - Send printer error messages to the parent process to report to the user. r=Mossop

Bug 1199434 - Send printer error messages to the parent process to report to the user. r?Mossop

The printing back-end used to be in charge of opening up an error dialog
when things go wrong with printing. Now we fire an event and let PrintUtils
do the work of showing the error message. This has the added bonus of making
the error messages work with e10s.
Attachment #8661479 - Flags: review?(dtownsend)
Comment on attachment 8661479 [details]
MozReview Request: Bug 1199434 - Send printer error messages to the parent process to report to the user. r=Mossop

https://reviewboard.mozilla.org/r/19365/#review17459

::: toolkit/components/printing/content/printUtils.js:314
(Diff revision 3)
> +  handlePrintingError(nsresult, isPrinting) {

displayPrintingError is more appropriate.
Attachment #8661479 - Flags: review?(dtownsend) → review+
Comment on attachment 8661476 [details]
MozReview Request: Bug 1199434 - Fire an event when the print engine encounters an error. r=smaug

Please use C++ casting for double, not C.
Attachment #8661476 - Flags: review?(bugs) → review+
Comment on attachment 8661476 [details]
MozReview Request: Bug 1199434 - Fire an event when the print engine encounters an error. r=smaug

Bug 1199434 - Fire an event when the print engine encounters an error. r=smaug

The print engine used to directly cause a prompt to be displayed in the most
recent window in the event of an error. This patch causes the print engine to
fire an event instead so that the front-end can choose to display or ignore
the error.
Attachment #8661476 - Attachment description: MozReview Request: Bug 1199434 - Fire an event when the print engine encounters an error. r?smaug → MozReview Request: Bug 1199434 - Fire an event when the print engine encounters an error. r=smaug
Attachment #8661476 - Flags: review+
Attachment #8661479 - Attachment description: MozReview Request: Bug 1199434 - Send printer error messages to the parent process to report to the user. r?Mossop → MozReview Request: Bug 1199434 - Send printer error messages to the parent process to report to the user. r=Mossop
Comment on attachment 8661479 [details]
MozReview Request: Bug 1199434 - Send printer error messages to the parent process to report to the user. r=Mossop

Bug 1199434 - Send printer error messages to the parent process to report to the user. r=Mossop

The printing back-end used to be in charge of opening up an error dialog
when things go wrong with printing. Now we fire an event and let PrintUtils
do the work of showing the error message. This has the added bonus of making
the error messages work with e10s.
Comment on attachment 8661476 [details]
MozReview Request: Bug 1199434 - Fire an event when the print engine encounters an error. r=smaug

Bug 1199434 - Fire an event when the print engine encounters an error. r=smaug

The print engine used to directly cause a prompt to be displayed in the most
recent window in the event of an error. This patch causes the print engine to
fire an event instead so that the front-end can choose to display or ignore
the error.
Comment on attachment 8661479 [details]
MozReview Request: Bug 1199434 - Send printer error messages to the parent process to report to the user. r=Mossop

Bug 1199434 - Send printer error messages to the parent process to report to the user. r=Mossop

The printing back-end used to be in charge of opening up an error dialog
when things go wrong with printing. Now we fire an event and let PrintUtils
do the work of showing the error message. This has the added bonus of making
the error messages work with e10s.
Comment on attachment 8661476 [details]
MozReview Request: Bug 1199434 - Fire an event when the print engine encounters an error. r=smaug

Bug 1199434 - Fire an event when the print engine encounters an error. r=smaug

The print engine used to directly cause a prompt to be displayed in the most
recent window in the event of an error. This patch causes the print engine to
fire an event instead so that the front-end can choose to display or ignore
the error.
Comment on attachment 8661479 [details]
MozReview Request: Bug 1199434 - Send printer error messages to the parent process to report to the user. r=Mossop

Bug 1199434 - Send printer error messages to the parent process to report to the user. r=Mossop

The printing back-end used to be in charge of opening up an error dialog
when things go wrong with printing. Now we fire an event and let PrintUtils
do the work of showing the error message. This has the added bonus of making
the error messages work with e10s.
https://hg.mozilla.org/mozilla-central/rev/e0f32c7b9250
https://hg.mozilla.org/mozilla-central/rev/6578d90d03a4
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
Has STR: --- → yes
See Also: → 1328072
You need to log in before you can comment on or make changes to this bug.