1199434 - [e10s] Print preview doesn't show alert if printer was't found.

Status: RESOLVED FIXED

(Core :: Print Preview, defect)

Description

[arni2033]

STR:   (Win7_64bit, Nightly 43.0a1 32bit   ID 20150827030213, new profile)
1. Open page http://example.org/ in remote browser
2. Open menu bar (Alt or F10), click File->Print Preview

Result:       No alerts, operation just aborts.
Expectations: Alert should be displayed, just like in non-e10s mode.

Video - Non-e10s: https://dl.dropboxusercontent.com/s/97pp74dtt5wwyod/Print%20preview%20-%20no%20printer%20-%20normal.webm?dl=0

Video - e10s:     https://dl.dropboxusercontent.com/s/vdn1igkcuc9ezl1/Print%20preview%20-%20no%20printer%20-%20e10s.webm?dl=0

Comment 1

[arni2033]

Um, I have Win7 x86_64 (not x86) if that matters... But I still think it's more general issue.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Yoink

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: MozReview Request: Bug 1199434 - Fire an event when the print engine encounters an error. r=smaug

Bug 1199434 - [e10s] Print preview doesn't show alert if printer was't found. r?Mossop, r?smaug

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8661476 [details]
MozReview Request: Bug 1199434 - Fire an event when the print engine encounters an error. r=smaug

Bug 1199434 - Fire an event when the print engine encounters an error. r?smaug

The print engine used to directly cause a prompt to be displayed in the most
recent window in the event of an error. This patch causes the print engine to
fire an event instead so that the front-end can choose to display or ignore
the error.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: MozReview Request: Bug 1199434 - Send printer error messages to the parent process to report to the user. r=Mossop

Bug 1199434 - Send printer error messages to the parent process to report to the user. r?Mossop

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8661476 [details]
MozReview Request: Bug 1199434 - Fire an event when the print engine encounters an error. r=smaug

Bug 1199434 - Fire an event when the print engine encounters an error. r?smaug

The print engine used to directly cause a prompt to be displayed in the most
recent window in the event of an error. This patch causes the print engine to
fire an event instead so that the front-end can choose to display or ignore
the error.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8661479 [details]
MozReview Request: Bug 1199434 - Send printer error messages to the parent process to report to the user. r=Mossop

Bug 1199434 - Send printer error messages to the parent process to report to the user. r?Mossop

The printing back-end used to be in charge of opening up an error dialog
when things go wrong with printing. Now we fire an event and let PrintUtils
do the work of showing the error message. This has the added bonus of making
the error messages work with e10s.

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8661476 [details]
MozReview Request: Bug 1199434 - Fire an event when the print engine encounters an error. r=smaug

Bug 1199434 - Fire an event when the print engine encounters an error. r?smaug

The print engine used to directly cause a prompt to be displayed in the most
recent window in the event of an error. This patch causes the print engine to
fire an event instead so that the front-end can choose to display or ignore
the error.

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8661479 [details]
MozReview Request: Bug 1199434 - Send printer error messages to the parent process to report to the user. r=Mossop

Bug 1199434 - Send printer error messages to the parent process to report to the user. r?Mossop

The printing back-end used to be in charge of opening up an error dialog
when things go wrong with printing. Now we fire an event and let PrintUtils
do the work of showing the error message. This has the added bonus of making
the error messages work with e10s.

Comment 10

[Dave Townsend [:mossop]]

Comment on attachment 8661479 [details]
MozReview Request: Bug 1199434 - Send printer error messages to the parent process to report to the user. r=Mossop

https://reviewboard.mozilla.org/r/19365/#review17459

::: toolkit/components/printing/content/printUtils.js:314
(Diff revision 3)
> +  handlePrintingError(nsresult, isPrinting) {

displayPrintingError is more appropriate.

Comment 11

[Olli Pettay [:smaug][[e-mail]](vacation until July 14)]

Comment on attachment 8661476 [details]
MozReview Request: Bug 1199434 - Fire an event when the print engine encounters an error. r=smaug

Please use C++ casting for double, not C.

Comment 12

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8661476 [details]
MozReview Request: Bug 1199434 - Fire an event when the print engine encounters an error. r=smaug

Bug 1199434 - Fire an event when the print engine encounters an error. r=smaug

The print engine used to directly cause a prompt to be displayed in the most
recent window in the event of an error. This patch causes the print engine to
fire an event instead so that the front-end can choose to display or ignore
the error.

Comment 13

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8661479 [details]
MozReview Request: Bug 1199434 - Send printer error messages to the parent process to report to the user. r=Mossop

Bug 1199434 - Send printer error messages to the parent process to report to the user. r=Mossop

The printing back-end used to be in charge of opening up an error dialog
when things go wrong with printing. Now we fire an event and let PrintUtils
do the work of showing the error message. This has the added bonus of making
the error messages work with e10s.

Comment 14

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8661476 [details]
MozReview Request: Bug 1199434 - Fire an event when the print engine encounters an error. r=smaug

Bug 1199434 - Fire an event when the print engine encounters an error. r=smaug

The print engine used to directly cause a prompt to be displayed in the most
recent window in the event of an error. This patch causes the print engine to
fire an event instead so that the front-end can choose to display or ignore
the error.

Comment 15

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8661479 [details]
MozReview Request: Bug 1199434 - Send printer error messages to the parent process to report to the user. r=Mossop

Bug 1199434 - Send printer error messages to the parent process to report to the user. r=Mossop

The printing back-end used to be in charge of opening up an error dialog
when things go wrong with printing. Now we fire an event and let PrintUtils
do the work of showing the error message. This has the added bonus of making
the error messages work with e10s.

Comment 16

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8661476 [details]
MozReview Request: Bug 1199434 - Fire an event when the print engine encounters an error. r=smaug

Bug 1199434 - Fire an event when the print engine encounters an error. r=smaug

The print engine used to directly cause a prompt to be displayed in the most
recent window in the event of an error. This patch causes the print engine to
fire an event instead so that the front-end can choose to display or ignore
the error.

Comment 17

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8661479 [details]
MozReview Request: Bug 1199434 - Send printer error messages to the parent process to report to the user. r=Mossop

Bug 1199434 - Send printer error messages to the parent process to report to the user. r=Mossop

The printing back-end used to be in charge of opening up an error dialog
when things go wrong with printing. Now we fire an event and let PrintUtils
do the work of showing the error message. This has the added bonus of making
the error messages work with e10s.

Comment 18

[Mike Conley (:mconley) (:⚙️)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e0f32c7b9250c15ea48ff2789934fcc3897bb12a
Bug 1199434 - Fire an event when the print engine encounters an error. r=smaug

https://hg.mozilla.org/integration/mozilla-inbound/rev/6578d90d03a42fbba7a56724d5e6c7e10f62ee99
Bug 1199434 - Send printer error messages to the parent process to report to the user. r=Mossop

Comment 19

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e0f32c7b9250
https://hg.mozilla.org/mozilla-central/rev/6578d90d03a4

Comment 20

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bugnotes

http://people.mozilla.org/~mconley2/bugnotes/bug-1199434.html